From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id C41D61A0063 for ; Thu, 4 Jun 2015 00:25:28 +1000 (AEST) Date: Wed, 3 Jun 2015 16:25:20 +0200 From: Jiri Olsa To: Andi Kleen Cc: Sukadev Bhattiprolu , mingo@redhat.com, Michael Ellerman , Arnaldo Carvalho de Melo , namhyung@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v13 12/14] perf, tools: Add support for event list topics Message-ID: <20150603142520.GA30890@krava> References: <1433265135-20426-1-git-send-email-sukadev@linux.vnet.ibm.com> <1433265135-20426-13-git-send-email-sukadev@linux.vnet.ibm.com> <20150602191641.GA3978@us.ibm.com> <20150603103229.GK1828@krava.redhat.com> <20150603125733.GS1187@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20150603125733.GS1187@tassilo.jf.intel.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Jun 03, 2015 at 05:57:33AM -0700, Andi Kleen wrote: > > please split at least the jevents Topic parsing from the rest > > idelay also the alias update and the display change > > What's the point of all these splits? It's already one logical unit, > not too large, and is bisectable. splitting the patch in logical pieces helps review and distro backporting You changed the parsing tool and perf alias code that uses the new output. IMO it's separate enough to be placed into separate patches. I believe the review would have been easier for me if those changes were separate, also easing my job when backporting this change later into the distro jirka