From: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
To: Benjamin Herrenschmidt <benh@au1.ibm.com>
Cc: Preeti U Murthy <preeti@linux.vnet.ibm.com>,
linux-pm@vger.kernel.org,
Daniel Lezcano <daniel.lezcano@linaro.org>,
rjw@rjwysocki.net, linux-kernel@vger.kernel.org, anton@samba.org,
Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] cpuidle: powernv/pseries: Decrease the snooze residency
Date: Wed, 3 Jun 2015 21:05:57 +0530 [thread overview]
Message-ID: <20150603153557.GA5983@dirshya.in.ibm.com> (raw)
In-Reply-To: <1433036302.4526.15.camel@au1.ibm.com>
* Benjamin Herrenschmidt <benh@au1.ibm.com> [2015-05-30 20:38:22]:
> On Sat, 2015-05-30 at 11:31 +0530, Vaidyanathan Srinivasan wrote:
> > In shared lpar case, spinning in guest context may potentially take
> > away cycles from other lpars waiting to run on the same physical cpu.
> >
> > So the policy in shared lpar case is to let PowerVM hypervisor know
> > immediately that the guest cpu is idle which will allow the hypervisor
> > to use the cycles for other tasks/lpars.
>
> But that will have negative side effects under KVM no ?
Yes, you have a good point. If one of the thread in the core goes to
cede, it can still come back quickly since the KVM guest context is
not switched yet. But in single threaded guest, this can force an
unnecessary exit/context switch overhead.
Now that we have fixed the snooze loop to be bounded and exit
predictably, KVM guest should actually use snooze state to improve
latency.
I will test this scenario and enable snooze state for KVM guest.
> Suresh mentioned something with his new directed interrupts code that we
> had many cases where the interrupts ended up arriving shortly after we
> exited to host for NAP'ing ...
>
> Snooze might fix it...
Right. This scenario is worth experimenting and then introduce snooze
loop for guest.
--Vaidy
prev parent reply other threads:[~2015-06-03 15:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 12:32 [PATCH] cpuidle: powernv/pseries: Decrease the snooze residency Shilpasri G Bhat
2015-05-29 13:47 ` Preeti U Murthy
2015-05-30 6:01 ` Vaidyanathan Srinivasan
2015-05-30 8:00 ` Preeti U Murthy
2015-05-31 1:38 ` Benjamin Herrenschmidt
2015-06-03 15:35 ` Vaidyanathan Srinivasan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150603153557.GA5983@dirshya.in.ibm.com \
--to=svaidy@linux.vnet.ibm.com \
--cc=anton@samba.org \
--cc=benh@au1.ibm.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=preeti@linux.vnet.ibm.com \
--cc=rjw@rjwysocki.net \
--cc=shilpa.bhat@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).