From: Zidan Wang <zidan.wang@freescale.com>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: <broonie@kernel.org>, <perex@perex.cz>, <tiwai@suse.de>,
<timur@tabi.org>, <Xiubo.Lee@gmail.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<alsa-devel@alsa-project.org>, <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [alsa-devel][PATCH] ASoC: fsl: add imx-wm8960 machine driver
Date: Fri, 12 Jun 2015 16:09:32 +0800 [thread overview]
Message-ID: <20150612080930.GB23608@shlinux2> (raw)
In-Reply-To: <20150611155106.GA3036@Asurada>
On Thu, Jun 11, 2015 at 08:51:07AM -0700, Nicolin Chen wrote:
> On Thu, Jun 11, 2015 at 07:10:00PM +0800, Zidan Wang wrote:
>
> > > > This imx-wm8960 device-tree-only machine driver works with sai driver
> > > > and have below feature.
> > > > * support codec master and slave mode
> > > > * support headphone jack detect
> > > > * support headphone and micphone jack event
> > > > * support asrc<->sai<->wm8960 mode
> > > >
> > > > Signed-off-by: Zidan Wang <zidan.wang@freescale.com>
> > >
> > > Above all, could you merge this into fsl-asoc-card?
> > >
> > > It'd be nicer to have jack detection over there. And we can
> > > put PLL settings to the codec driver as Mark suggested.
>
> > I want to modify imx-wm8960 and upstream it because our release is using it now. After
> > upstreaming imx-wm8960, i will try to merge it to fsl-asoc-card.
>
> I knew your intention. That's why I suggested you to merge it directly
> to fsl-asoc-card instead of making a duplicated copy of that. Remember
> that getting code upstream should be a chance for us to improve thing.
>
> If you find painstaking to handle it in parallel, you can focus on the
> improvements of the WM8960 driver while I would help you on the dai-
> link part. How about this?
>
> Nicolin
The new imx7 release have two new codec wm8958 and wm8960. So we have two machine driver
imx-wm8960 and imx-wm8958 which should be upstreamed. I am appreciate that you can help me
merge the imx-wm8960 to fsl-asoc-card. And i will focus on wm8960 and wm8958 driver. And i
will try to merge imx-wm8958 to fsl-asoc-card.
Best Regards,
Zidan Wang
prev parent reply other threads:[~2015-06-12 8:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 8:26 [alsa-devel][PATCH] ASoC: fsl: add imx-wm8960 machine driver Zidan Wang
2015-06-10 18:09 ` Mark Brown
2015-06-10 18:36 ` Nicolin Chen
2015-06-11 11:10 ` Zidan Wang
2015-06-11 15:51 ` Nicolin Chen
2015-06-12 8:09 ` Zidan Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150612080930.GB23608@shlinux2 \
--to=zidan.wang@freescale.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=timur@tabi.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).