From: Nishanth Aravamudan <nacc@linux.vnet.ibm.com>
To: Gavin Shan <gwshan@linux.vnet.ibm.com>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH kernel] powerpc/powernv/ioda2: Add devices only from buses which belong to PE
Date: Fri, 12 Jun 2015 08:06:43 -0700 [thread overview]
Message-ID: <20150612150643.GA55122@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150612064703.GA17776@gwshan>
On 12.06.2015 [16:47:03 +1000], Gavin Shan wrote:
> On Fri, Jun 12, 2015 at 04:19:17PM +1000, Alexey Kardashevskiy wrote:
> >The existing code puts all devices from a root PE to the same IOMMU group.
> >However it is a possible situation when subordinate buses belong to
> >separate PEs, in this case devices from these subordinate buses
> >should be added to lower level PE rather to the root PE.
> >
> >This limits pnv_ioda_setup_bus_dma() invocation to only PEs which own
> >all subordinate buses.
> >
> >Suggested-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
> >Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>
> Alexey, I think it's good candidate for stable.
Why? This commit message doesn't imply there is a serious bug just a
"possible" (does that mean theoretical?) situtation and the following:
> >This would be nice to have together with the DDW patchset.
> >This does not fix anything DDW patchset did, it fixes IOMMU
> >groups management which is essential for the whole feature to work.
implies it is both related and independent of DDW?
-Nish
next prev parent reply other threads:[~2015-06-12 15:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-12 6:19 [PATCH kernel] powerpc/powernv/ioda2: Add devices only from buses which belong to PE Alexey Kardashevskiy
2015-06-12 6:47 ` Gavin Shan
2015-06-12 15:06 ` Nishanth Aravamudan [this message]
2015-06-12 16:47 ` Alexey Kardashevskiy
2015-06-15 0:11 ` Gavin Shan
2015-06-15 6:49 ` [kernel] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150612150643.GA55122@linux.vnet.ibm.com \
--to=nacc@linux.vnet.ibm.com \
--cc=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).