linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Vaibhav Jain <vaibhav@linux.vnet.ibm.com>,
	linuxppc-dev@lists.ozlabs.org, benh@kernel.crashing.org
Cc: Neelesh Gupta <neelegup@linux.vnet.ibm.com>,
	Cyril Bur <cyrilbur@gmail.com>,
	Vaibhav Jain <vaibhav@linux.vnet.ibm.com>
Subject: Re: [v3] powerpc/configs: enable RTC class support
Date: Wed, 17 Jun 2015 15:43:15 +1000 (AEST)	[thread overview]
Message-ID: <20150617054315.9BABF140290@ozlabs.org> (raw)
In-Reply-To: <1433155735-23751-1-git-send-email-vaibhav@linux.vnet.ibm.com>

On Mon, 2015-01-06 at 10:48:55 UTC, Vaibhav Jain wrote:
> A working rtc kernel driver is needed so that hwclock can synchronize
> system clock to rtc during shutdown/boot. We already have a rtc platform
> driver for power arch located at drivers/rtc/rtc-opal.c However it
> depends on CONFIG_RTC_CLASS which is disabled by default. So this driver
> is not compiled with pseries defconfig as rtc class support is missing
> from the kernel.
> 
> We fix this by enabling rtc class support in pseries defconfig so that
> this driver gets enabled and is compiled into the pseries kernel.

So that seems fair enough.

But, it disables CONFIG_GEN_RTC. Which *I think* means we won't get an RTC
driver at all on pseries machines.

There's some history between those two options but I don't know it off the top
of my head. Ben should know?

cheers

  reply	other threads:[~2015-06-17  5:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-01 10:48 [PATCH v3] powerpc/configs: enable RTC class support Vaibhav Jain
2015-06-17  5:43 ` Michael Ellerman [this message]
2015-06-24  7:45   ` [v3] " Vaibhav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150617054315.9BABF140290@ozlabs.org \
    --to=mpe@ellerman.id.au \
    --cc=benh@kernel.crashing.org \
    --cc=cyrilbur@gmail.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=neelegup@linux.vnet.ibm.com \
    --cc=vaibhav@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).