From: Steven Rostedt <rostedt@goodmis.org>
To: Torsten Duwe <duwe@lst.de>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Jiri Kosina <jkosina@suse.cz>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH 1/4] ppc64 FTRACE_WITH_REGS implementation
Date: Fri, 19 Jun 2015 09:26:25 -0400 [thread overview]
Message-ID: <20150619092625.17e5c9a1@grimm.local.home> (raw)
In-Reply-To: <20150618162107.GB6546@lst.de>
On Thu, 18 Jun 2015 18:21:07 +0200
Torsten Duwe <duwe@lst.de> wrote:
> Implement FTRACE_WITH_REGS for powerpc64, on ELF ABI v2.
> Initial work started by Vojtech Pavlik, used with permission.
>
> * arch/powerpc/kernel/entry_64.S:
> - enhance _mcount with a stub to test (ftrace_trace_function == &ftrace_stub)
> as suggested in Documentation/trace/ftrace-design.txt
> (for reference only, patched out at runtime)
> - Implement an effective ftrace_caller that works from within the kernel
> binary as well as from modules.
> * arch/powerpc/kernel/ftrace.c:
> - be prepared to deal with ppc64 ELV ABI v2, especially calls to _mcount
> that result from gcc -mprofile-kernel
> * arch/powerpc/kernel/module_64.c:
> - do not save the TOC pointer on the trampoline when the destination
> is ftrace_caller. This trampoline jump happens from a function prologue
> before a new stack frame is set up, so bad things may happen otherwise...
> - relax is_module_trampoline() to recognise the modified trampoline.
>
> Signed-off-by: Torsten Duwe <duwe@suse.de>
> --
FYI, the standard notation after the change log is '---' not '--'. That
way git will chop off this from the change log. When I did a git am -s
on this patch I had:
Signed-off-by: Torsten Duwe <duwe@suse.de>
--
arch/powerpc/include/asm/ftrace.h | 5 +
arch/powerpc/kernel/entry_64.S | 112 +++++++++++++++++++++++++++++++-------
arch/powerpc/kernel/ftrace.c | 67 ++++++++++++++++++++--
arch/powerpc/kernel/module_64.c | 33 ++++++++++-
4 files changed, 186 insertions(+), 31 deletions(-)
--
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
> arch/powerpc/include/asm/ftrace.h | 5 +
> arch/powerpc/kernel/entry_64.S | 112 +++++++++++++++++++++++++++++++-------
> arch/powerpc/kernel/ftrace.c | 67 ++++++++++++++++++++--
> arch/powerpc/kernel/module_64.c | 33 ++++++++++-
> 4 files changed, 186 insertions(+), 31 deletions(-)
> --
> diff --git a/arch/powerpc/include/asm/ftrace.h b/arch/powerpc/include/asm/ftrace.h
> index e366187..6111191 100644
> --- a/arch/powerpc/include/asm/ftrace.h
> +++ b/arch/powerpc/include/asm/ftrace.h
next prev parent reply other threads:[~2015-06-19 13:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 9:53 [PATCH 0/4] resend: ppc64 LE ABI v2 ftrace-with-regs implementation Torsten Duwe
2015-06-11 9:58 ` [PATCH 1/4] ppc64 FTRACE_WITH_REGS implementation Torsten Duwe
2015-06-11 9:59 ` [PATCH 2/4] ppc64 ftrace_with_regs configuration variables Torsten Duwe
2015-06-11 10:01 ` [PATCH 3/4] ppc64 ftrace_with_regs: spare early boot and low level code Torsten Duwe
2015-06-11 10:03 ` [PATCH 4/4] ppc64 ftrace_with_regs recursion protection Torsten Duwe
2015-06-18 16:17 ` [RESEND PATCH 0/4] ppc64 LE ABI v2 ftrace-with-regs implementation Torsten Duwe
2015-06-18 16:21 ` [RESEND PATCH 1/4] ppc64 FTRACE_WITH_REGS implementation Torsten Duwe
2015-06-18 16:49 ` Steven Rostedt
2015-06-19 12:01 ` Torsten Duwe
2015-06-19 13:26 ` Steven Rostedt [this message]
2015-06-18 16:22 ` [RESEND PATCH 2/4] ppc64 ftrace_with_regs configuration variables Torsten Duwe
2015-06-18 16:24 ` [RESEND PATCH 3/4] ppc64 ftrace_with_regs: spare early boot and low level code Torsten Duwe
2015-06-18 16:25 ` [RESEND PATCH 4/4] ppc64 ftrace_with_regs recursion protection Torsten Duwe
2015-06-18 16:55 ` [RESEND PATCH 0/4] ppc64 LE ABI v2 ftrace-with-regs implementation Steven Rostedt
2015-06-19 12:00 ` Torsten Duwe
2015-06-19 12:40 ` Steven Rostedt
2015-06-19 13:18 ` Torsten Duwe
2015-06-19 2:49 ` Michael Ellerman
2015-06-19 7:15 ` Denis Kirjanov
2015-06-19 12:17 ` Torsten Duwe
2015-06-19 12:41 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150619092625.17e5c9a1@grimm.local.home \
--to=rostedt@goodmis.org \
--cc=duwe@lst.de \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).