From: David Miller <davem@davemloft.net>
To: alex.popov@linux.com
Cc: pantelis.antoniou@gmail.com, vbordug@ru.mvista.com,
christophe.leroy@c-s.fr, linuxppc-dev@lists.ozlabs.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] net: fs_enet: Fix NETIF_F_SG feature for Freescale MPC5121
Date: Tue, 23 Jun 2015 06:39:26 -0700 (PDT) [thread overview]
Message-ID: <20150623.063926.723221732046739833.davem@davemloft.net> (raw)
In-Reply-To: <1434839566-31704-1-git-send-email-alex.popov@linux.com>
From: Alexander Popov <alex.popov@linux.com>
Date: Sun, 21 Jun 2015 01:32:46 +0300
> Commit 4fc9b87bae25 ("net: fs_enet: Implement NETIF_F_SG feature")
> brings a trouble to Freescale MPC512x: a kernel oops happens
> during sending non-linear sk_buff with .data not aligned by 4.
>
> Log quotation:
...
> The reason:
>
> MPC5121 FEC requires 4-byte alignment for TX data buffer and calls
> tx_skb_align_workaround() for copying sk_buff with not aligned .data to a new
> sk_buff with aligned one. But tx_skb_align_workaround() uses
> skb_copy_from_linear_data() which doesn't work for non-linear sk_buff:
> a new sk_buff has non-zero nr_frags and zero .data_len.
>
> So improve the condition of calling tx_skb_align_workaround() and use
> skb_linearize() in it.
>
> Signed-off-by: Alexander Popov <alex.popov@linux.com>
Applied, thanks.
prev parent reply other threads:[~2015-06-23 13:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-20 22:32 [PATCH v2 1/1] net: fs_enet: Fix NETIF_F_SG feature for Freescale MPC5121 Alexander Popov
2015-06-23 13:39 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150623.063926.723221732046739833.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alex.popov@linux.com \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=pantelis.antoniou@gmail.com \
--cc=vbordug@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).