From: Paul Mackerras <paulus@samba.org>
To: Scott Wood <scottwood@freescale.com>
Cc: Samuel Mendoza-Jonas <sam.mj@au1.ibm.com>, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/2] powerpc/kexec: Reset secondary cpu endianess before kexec
Date: Wed, 8 Jul 2015 14:04:56 +1000 [thread overview]
Message-ID: <20150708040455.GA9086@pale.ozlabs.ibm.com> (raw)
In-Reply-To: <1436322938.2658.60.camel@freescale.com>
On Tue, Jul 07, 2015 at 09:35:38PM -0500, Scott Wood wrote:
>
> Also, it would be better to use label subtraction rather than hardcoding
> "28", and the bcl instruction would be more readable as "bl <label>".
I agree about using labels, but "bcl 20,31,foo" is not the same thing
as "bl foo". The former is a form of bl that doesn't perturb the link
stack and is therefore better for performance when you're not going to
do a matching blr later (not that performance is at all critical
here).
Paul.
next prev parent reply other threads:[~2015-07-08 4:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 1:23 [PATCH 1/2] powerpc/kexec: Reset secondary cpu endianess before kexec Samuel Mendoza-Jonas
2015-07-08 1:23 ` [PATCH 2/2] powerpc/kexec: Reset HILE before kexec_sequence Samuel Mendoza-Jonas
2015-07-08 6:14 ` Stewart Smith
2015-07-08 2:35 ` [PATCH 1/2] powerpc/kexec: Reset secondary cpu endianess before kexec Scott Wood
2015-07-08 4:04 ` Paul Mackerras [this message]
2015-07-08 4:22 ` Scott Wood
2015-07-09 15:42 ` Segher Boessenkool
2015-07-09 20:27 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150708040455.GA9086@pale.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sam.mj@au1.ibm.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).