From: Michael Ellerman <mpe@ellerman.id.au>
To: Neelesh Gupta <neelegup@linux.vnet.ibm.com>,
linuxppc-dev@ozlabs.org, jk@ozlabs.org
Cc: neelegup@linux.vnet.ibm.com
Subject: Re: ipmi/powernv: Fix a minor bug
Date: Wed, 8 Jul 2015 20:42:01 +1000 (AEST) [thread overview]
Message-ID: <20150708104201.52B3D140AF3@ozlabs.org> (raw)
In-Reply-To: <20150708062702.11242.47257.stgit@localhost.localdomain>
On Wed, 2015-08-07 at 06:27:28 UTC, Neelesh Gupta wrote:
> If the OPAL call to receive the ipmi message fails, then we free up the smi
> message before returning. But, the driver still holds the reference to old
> smi message in the 'cur_msg' which is dangerous if the driver derefernces it
> later and it will further block the subsequent ipmi operations.
This doesn't sound like "a minor bug" ?
What are the actual symptoms of the bug? Does it crash, always, sometimes? Does
it actually "block the subsequent ipmi operations"?
Even if this *is* a minor bug, please give it a proper subject that describes
what it does.
Also which commit introduced the bug?
And finally you don't seem to have CC'ed the ipmi maintainers?
cheers
next prev parent reply other threads:[~2015-07-08 10:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 6:27 [PATCH] ipmi/powernv: Fix a minor bug Neelesh Gupta
2015-07-08 10:42 ` Michael Ellerman [this message]
2015-07-09 10:35 ` Neelesh Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150708104201.52B3D140AF3@ozlabs.org \
--to=mpe@ellerman.id.au \
--cc=jk@ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=neelegup@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).