From: Michael Ellerman <mpe@ellerman.id.au>
To: Ian Munsie <imunsie@au1.ibm.com>
Cc: Matt Ochs <mrochs@us.ibm.com>,
linuxppc-dev <linuxppc-dev@ozlabs.org>, mikey <mikey@neuling.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Ian Munsie <imunsie@au1.ibm.com>
Subject: Re: [2/2] cxl: Fail mmap if requested mapping is larger than assigned problem state area
Date: Wed, 8 Jul 2015 20:54:09 +1000 (AEST) [thread overview]
Message-ID: <20150708105409.9D407140B0E@ozlabs.org> (raw)
In-Reply-To: <1436247946-16292-2-git-send-email-imunsie@au.ibm.com>
On Tue, 2015-07-07 at 05:45:46 UTC, Ian Munsie wrote:
> From: Ian Munsie <imunsie@au1.ibm.com>
>
> This patch makes the mmap call fail outright if the requested region is
> larger than the problem state area assigned to the context so the error
> is reported immediately rather than waiting for an attempt to access an
> address out of bounds.
>
> Although we never expect users to map more than the assigned problem
> state area and are not aware of anyone doing this (other than for
> testing), this does have the potential to break users if someone has
> used a larger range regardless. I'm submitting it for consideration, but
> if this change is not considered acceptable the previous patch is
> sufficient to prevent access out of bounds without breaking anyone.
>
> Signed-off-by: Ian Munsie <imunsie@au1.ibm.com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/cgit/linux/kernel/git/powerpc/linux.git/commit/?h=fixes&id=5caaf5346892d1e7f0b8b7223062644f8538483f
cheers
next prev parent reply other threads:[~2015-07-08 10:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 5:45 [PATCH 1/2] cxl: Fix off by one error allowing subsequent mmap page to be accessed Ian Munsie
2015-07-07 5:45 ` [PATCH 2/2] cxl: Fail mmap if requested mapping is larger than assigned problem state area Ian Munsie
2015-07-08 10:54 ` Michael Ellerman [this message]
2015-07-08 10:54 ` [1/2] cxl: Fix off by one error allowing subsequent mmap page to be accessed Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150708105409.9D407140B0E@ozlabs.org \
--to=mpe@ellerman.id.au \
--cc=imunsie@au1.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=mrochs@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).