From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id F1C771A1992 for ; Wed, 8 Jul 2015 20:54:09 +1000 (AEST) In-Reply-To: <1436247946-16292-2-git-send-email-imunsie@au.ibm.com> To: Ian Munsie From: Michael Ellerman Cc: Matt Ochs , linuxppc-dev , mikey , linux-kernel , Ian Munsie Subject: Re: [2/2] cxl: Fail mmap if requested mapping is larger than assigned problem state area Message-Id: <20150708105409.9D407140B0E@ozlabs.org> Date: Wed, 8 Jul 2015 20:54:09 +1000 (AEST) List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2015-07-07 at 05:45:46 UTC, Ian Munsie wrote: > From: Ian Munsie > > This patch makes the mmap call fail outright if the requested region is > larger than the problem state area assigned to the context so the error > is reported immediately rather than waiting for an attempt to access an > address out of bounds. > > Although we never expect users to map more than the assigned problem > state area and are not aware of anyone doing this (other than for > testing), this does have the potential to break users if someone has > used a larger range regardless. I'm submitting it for consideration, but > if this change is not considered acceptable the previous patch is > sufficient to prevent access out of bounds without breaking anyone. > > Signed-off-by: Ian Munsie Applied to powerpc fixes, thanks. https://git.kernel.org/cgit/linux/kernel/git/powerpc/linux.git/commit/?h=fixes&id=5caaf5346892d1e7f0b8b7223062644f8538483f cheers