linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: linuxppc-dev@lists.ozlabs.org
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Julia Lawall <Julia.Lawall@lip6.fr>,
	Jiang Liu <jiang.liu@linux.intel.com>
Subject: [patch 18/20] powerpc/mpc5121: Prepare cpld_pic_cascade for irq argument removal
Date: Mon, 13 Jul 2015 20:50:28 -0000	[thread overview]
Message-ID: <20150713135740.499139784@linutronix.de> (raw)
In-Reply-To: 20150713135648.540293392@linutronix.de

The irq argument of most interrupt flow handlers is unused or merily
used instead of a local variable. The handlers which need the irq
argument can retrieve the irq number from the irq descriptor.

Search and update was done with coccinelle and the invaluable help of
Julia Lawall.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Jiang Liu <jiang.liu@linux.intel.com>

---
 arch/powerpc/platforms/512x/mpc5121_ads_cpld.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Index: tip/arch/powerpc/platforms/512x/mpc5121_ads_cpld.c
===================================================================
--- tip.orig/arch/powerpc/platforms/512x/mpc5121_ads_cpld.c
+++ tip/arch/powerpc/platforms/512x/mpc5121_ads_cpld.c
@@ -105,8 +105,10 @@ cpld_pic_get_irq(int offset, u8 ignore,
 }
 
 static void
-cpld_pic_cascade(unsigned int irq, struct irq_desc *desc)
+cpld_pic_cascade(unsigned int __irq, struct irq_desc *desc)
 {
+	unsigned int irq;
+
 	irq = cpld_pic_get_irq(0, PCI_IGNORE, &cpld_regs->pci_status,
 		&cpld_regs->pci_mask);
 	if (irq != NO_IRQ) {

  parent reply	other threads:[~2015-07-13 20:50 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-13 20:50 [patch 00/20] powerpc: Interrupt cleanups and API change preparation Thomas Gleixner
2015-07-13 20:50 ` [patch 01/20] powerpc/media5200: Consolidate chained IRQ handler install/remove Thomas Gleixner
2015-07-13 20:50 ` [patch 02/20] powerpc/52xx: " Thomas Gleixner
2015-07-13 20:50 ` [patch 03/20] powerpc/pq2ads: " Thomas Gleixner
2015-07-13 20:50 ` [patch 04/20] powerpc/axon_msi: " Thomas Gleixner
2015-07-13 20:50 ` [patch 05/20] powerpc/cell: " Thomas Gleixner
2015-07-13 20:50 ` [patch 06/20] powerpc/spider-pic: " Thomas Gleixner
2015-07-13 20:50 ` [patch 07/20] powerpc/hlwd-pic: " Thomas Gleixner
2015-07-13 20:50 ` [patch 08/20] powerpc/holly: " Thomas Gleixner
2015-07-13 20:50 ` [patch 09/20] powerpc/mpc7448: " Thomas Gleixner
2015-07-13 20:50 ` [patch 10/20] powerpc/mpic: " Thomas Gleixner
2015-07-13 20:50 ` [patch 11/20] powerpc/qe_ic: " Thomas Gleixner
2015-07-13 20:50 ` [patch 12/20] powerpc/uic: " Thomas Gleixner
2015-07-13 20:50 ` [patch 13/20] powerpc/irq: Use access helper irq_data_get_affinity_mask() Thomas Gleixner
2015-07-13 20:50 ` [patch 14/20] powerpc/mpc52xx: Use irq_set_handler_locked() Thomas Gleixner
2015-07-13 20:50 ` [patch 15/20] powerpc/cpm2: " Thomas Gleixner
2015-07-13 20:50 ` [patch 16/20] powerpc/ipic: " Thomas Gleixner
2015-07-13 20:50 ` [patch 17/20] powerpc/mpc8xx: " Thomas Gleixner
2015-07-13 20:50 ` Thomas Gleixner [this message]
2015-07-13 20:50 ` [patch 19/20] powerpc/85xx: Prepare cascade handlers for irq argument removal Thomas Gleixner
2015-07-13 20:50 ` [patch 20/20] powerpc/cell: Prepare iic_ioexc_cascade " Thomas Gleixner
2015-07-16  4:37 ` [patch 00/20] powerpc: Interrupt cleanups and API change preparation Michael Ellerman
2015-07-31 21:47   ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150713135740.499139784@linutronix.de \
    --to=tglx@linutronix.de \
    --cc=Julia.Lawall@lip6.fr \
    --cc=benh@kernel.crashing.org \
    --cc=jiang.liu@linux.intel.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).