From: Vivek Goyal <vgoyal@redhat.com>
To: dwalker@fifo99.com
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mips@linux-mips.org, Baoquan He <bhe@redhat.com>,
linux-sh@vger.kernel.org, linux-s390@vger.kernel.org,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@kernel.org>,
HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
linuxppc-dev@lists.ozlabs.org, linux-metag@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] panic: Disable crash_kexec_post_notifiers if kdump is not available
Date: Tue, 14 Jul 2015 11:02:08 -0400 [thread overview]
Message-ID: <20150714150208.GD10792@redhat.com> (raw)
In-Reply-To: <20150714135919.GA18333@fifo99.com>
On Tue, Jul 14, 2015 at 01:59:19PM +0000, dwalker@fifo99.com wrote:
> On Mon, Jul 13, 2015 at 08:19:45PM -0500, Eric W. Biederman wrote:
> > dwalker@fifo99.com writes:
> >
> > > On Fri, Jul 10, 2015 at 08:41:28AM -0500, Eric W. Biederman wrote:
> > >> Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com> writes:
> > >>
> > >> > You can call panic notifiers and kmsg dumpers before kdump by
> > >> > specifying "crash_kexec_post_notifiers" as a boot parameter.
> > >> > However, it doesn't make sense if kdump is not available. In that
> > >> > case, disable "crash_kexec_post_notifiers" boot parameter so that
> > >> > you can't change the value of the parameter.
> > >>
> > >> Nacked-by: "Eric W. Biederman" <ebiederm@xmission.com>
> > >
> > > I think it would make sense if he just replaced "kdump" with "kexec".
> >
> > It would be less insane, however it still makes no sense as without
> > kexec on panic support crash_kexec is a noop. So the value of the
> > seeting makes no difference.
>
> Can you explain more, I don't really understand what you mean. Are you suggesting
> the whole "crash_kexec_post_notifiers" feature has no value ?
Daniel,
BTW, why are you using crash_kexec_post_notifiers commandline? Why not
without it?
Thanks
Vivek
next prev parent reply other threads:[~2015-07-14 15:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 11:33 [PATCH 0/3] kexec: crash_kexec_post_notifiers boot option related fixes Hidehiro Kawai
2015-07-10 11:33 ` [PATCH 2/3] kexec: Pass panic message to crash_kexec() Hidehiro Kawai
2015-07-10 11:33 ` [PATCH 3/3] kexec: Change the timing of callbacks related to "crash_kexec_post_notifiers" boot option Hidehiro Kawai
2015-07-14 14:42 ` Vivek Goyal
2015-07-15 3:09 ` Masami Hiramatsu
2015-07-10 11:33 ` [PATCH 1/3] panic: Disable crash_kexec_post_notifiers if kdump is not available Hidehiro Kawai
2015-07-10 13:41 ` Eric W. Biederman
2015-07-13 20:26 ` dwalker
2015-07-14 1:19 ` Eric W. Biederman
2015-07-14 13:59 ` dwalker
2015-07-14 14:20 ` Vivek Goyal
2015-07-14 15:02 ` Vivek Goyal [this message]
2015-07-14 15:34 ` dwalker
2015-07-14 15:40 ` Vivek Goyal
2015-07-14 15:48 ` dwalker
2015-07-14 16:16 ` Vivek Goyal
2015-07-14 17:06 ` Eric W. Biederman
2015-07-14 17:29 ` dwalker
2015-07-14 17:55 ` Vivek Goyal
2015-07-14 18:01 ` Eric W. Biederman
2015-07-14 18:23 ` Vivek Goyal
2015-07-15 5:16 ` Masami Hiramatsu
2015-07-15 10:49 ` Hidehiro Kawai
2015-07-14 1:56 ` Hidehiro Kawai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150714150208.GD10792@redhat.com \
--to=vgoyal@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=d.hatayama@jp.fujitsu.com \
--cc=dwalker@fifo99.com \
--cc=ebiederm@xmission.com \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-metag@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).