From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Mark Brown <broonie@kernel.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-spi@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
kernel@pengutronix.de, Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] spi: mpc512x-psc: add support for Freescale MPC5125
Date: Wed, 15 Jul 2015 09:40:19 +0200 [thread overview]
Message-ID: <20150715074018.GD1426@pengutronix.de> (raw)
In-Reply-To: <20150714095442.GO11162@sirena.org.uk>
On Tue, Jul 14, 2015 at 10:54:42AM +0100, Mark Brown wrote:
> On Tue, Jul 14, 2015 at 11:19:56AM +0200, Uwe Kleine-König wrote:
>
> > static const struct of_device_id mpc512x_psc_spi_of_match[] = {
> > - { .compatible = "fsl,mpc5121-psc-spi", },
> > + { .compatible = "fsl,mpc5121-psc-spi", .data = (void *)TYPE_MPC5121 },
> > + { .compatible = "fsl,mpc5125-psc-spi", .data = (void *)TYPE_MPC5125 },
> > {},
>
> The code seems fine but this should update the binding document to
> include the new compatible string.
I don't find fsl,mpc5121-psc-spi documented either. The best I found is
ocumentation/devicetree/bindings/powerpc/fsl/mpc5121-psc.txt which
describes fsl,mpc5121-psc-uart and fsl,mpc5121-psc.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2015-07-15 7:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 9:19 [PATCH] spi: mpc512x-psc: add support for Freescale MPC5125 Uwe Kleine-König
2015-07-14 9:54 ` Mark Brown
2015-07-15 7:40 ` Uwe Kleine-König [this message]
2015-07-16 13:32 ` Mark Brown
2015-07-16 19:35 ` [PATCH] dt-bindings: powerpc: adapt mpc5121-psc document to reality Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150715074018.GD1426@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=benh@kernel.crashing.org \
--cc=broonie@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-spi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).