From: Michael Ellerman <mpe@ellerman.id.au>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Ian Munsie <imunsie@au1.ibm.com>,
Michael Neuling <mikey@neuling.org>
Cc: Joe Perches <joe@perches.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [v3,1/2] cxl: Add explicit precision specifiers
Date: Thu, 16 Jul 2015 19:59:09 +1000 (AEST) [thread overview]
Message-ID: <20150716095909.3C4701402B5@ozlabs.org> (raw)
In-Reply-To: <1434022072-31754-1-git-send-email-linux@rasmusvillemoes.dk>
On Thu, 2015-11-06 at 11:27:51 UTC, Rasmus Villemoes wrote:
> C99 says that a precision given as simply '.' with no following digits
> or * should be interpreted as 0. The kernel's printf implementation,
> however, treats this case as if the precision was omitted. C99 also
> says that if both the precision and value are 0, no digits should be
> printed. Even if the kernel followed C99 to the letter, I don't think
> that would be particularly useful in these cases. For consistency with
> most other format strings in the file, use an explicit precision of 16
> and add a 0x prefix.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/80c394fab89649585089
cheers
next prev parent reply other threads:[~2015-07-16 9:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 13:26 [PATCH] cxl: Remove useless precision specifiers Rasmus Villemoes
2015-02-23 3:40 ` Ian Munsie
2015-02-23 6:42 ` Joe Perches
2015-02-23 10:55 ` [PATCH v2] cxl: Add explicit " Rasmus Villemoes
2015-02-23 14:59 ` Joe Perches
2015-02-24 0:12 ` Michael Ellerman
2015-02-24 4:28 ` Ian Munsie
2015-06-11 11:27 ` [PATCH v3 1/2] " Rasmus Villemoes
2015-06-11 11:27 ` [PATCH v3 2/2] cxl: use more common format specifier Rasmus Villemoes
2015-06-12 1:08 ` Ian Munsie
2015-07-16 9:59 ` Michael Ellerman [this message]
2015-02-24 4:25 ` [PATCH v2] cxl: Add explicit precision specifiers Ian Munsie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150716095909.3C4701402B5@ozlabs.org \
--to=mpe@ellerman.id.au \
--cc=imunsie@au1.ibm.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).