linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V2 1/2] Documentation/features: Add na key to arch-support.txt
@ 2015-07-17 10:51 Ananth N Mavinakayanahalli
  2015-07-17 10:52 ` [PATCH V2 2/2] kprobes: Mark OPTPROBES na for powerpc Ananth N Mavinakayanahalli
  2015-07-19  5:21 ` [PATCH V2 1/2] Documentation/features: Add na key to arch-support.txt Masami Hiramatsu
  0 siblings, 2 replies; 3+ messages in thread
From: Ananth N Mavinakayanahalli @ 2015-07-17 10:51 UTC (permalink / raw)
  To: masami.hiramatsu.pt, mpe, mingo; +Cc: linuxppc-dev, linux-kernel

To be used for features we will not support on a particular architecture.
The git log that adds this needs to provide the justification 'why?'

Signed-off-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
---
 Documentation/features/arch-support.txt |    1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/features/arch-support.txt b/Documentation/features/arch-support.txt
index d22a109..f2b272e 100644
--- a/Documentation/features/arch-support.txt
+++ b/Documentation/features/arch-support.txt
@@ -8,4 +8,5 @@ The meaning of entries in the tables is:
     | ok |  # feature supported by the architecture
     |TODO|  # feature not yet supported by the architecture
     | .. |  # feature cannot be supported by the hardware
+    | na |  # feature will not be supported by the architecture
 

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH V2 2/2] kprobes: Mark OPTPROBES na for powerpc
  2015-07-17 10:51 [PATCH V2 1/2] Documentation/features: Add na key to arch-support.txt Ananth N Mavinakayanahalli
@ 2015-07-17 10:52 ` Ananth N Mavinakayanahalli
  2015-07-19  5:21 ` [PATCH V2 1/2] Documentation/features: Add na key to arch-support.txt Masami Hiramatsu
  1 sibling, 0 replies; 3+ messages in thread
From: Ananth N Mavinakayanahalli @ 2015-07-17 10:52 UTC (permalink / raw)
  To: masami.hiramatsu.pt, mpe, mingo; +Cc: linuxppc-dev, linux-kernel

Kprobes uses a breakpoint instruction to trap into execution flow
and the probed instruction is single-stepped from an alternate location.

On some architectures like x86, under certain conditions, the OPTPROBES
feature enables replacing the probed instruction with a jump instead,
resulting in a significant perfomance boost (one single-step exception
is bypassed for each kprobe).

Powerpc has an in-kernel instruction emulator. Kprobes on powerpc uses
this emulator already and bypasses the single-step exception, with a
lot less complexity.

Hence, mark OPTPROBES na for powerpc.

Signed-off-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
---
 .../features/debug/optprobes/arch-support.txt      |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/features/debug/optprobes/arch-support.txt b/Documentation/features/debug/optprobes/arch-support.txt
index b8999d8..73662f9 100644
--- a/Documentation/features/debug/optprobes/arch-support.txt
+++ b/Documentation/features/debug/optprobes/arch-support.txt
@@ -27,7 +27,7 @@
     |       nios2: | TODO |
     |    openrisc: | TODO |
     |      parisc: | TODO |
-    |     powerpc: | TODO |
+    |     powerpc: |  na  |
     |        s390: | TODO |
     |       score: | TODO |
     |          sh: | TODO |

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH V2 1/2] Documentation/features: Add na key to arch-support.txt
  2015-07-17 10:51 [PATCH V2 1/2] Documentation/features: Add na key to arch-support.txt Ananth N Mavinakayanahalli
  2015-07-17 10:52 ` [PATCH V2 2/2] kprobes: Mark OPTPROBES na for powerpc Ananth N Mavinakayanahalli
@ 2015-07-19  5:21 ` Masami Hiramatsu
  1 sibling, 0 replies; 3+ messages in thread
From: Masami Hiramatsu @ 2015-07-19  5:21 UTC (permalink / raw)
  To: Ananth N Mavinakayanahalli, mpe, mingo; +Cc: linuxppc-dev, linux-kernel

On 2015/07/17 19:51, Ananth N Mavinakayanahalli wrote:
> To be used for features we will not support on a particular architecture.
> The git log that adds this needs to provide the justification 'why?'
> 
> Signed-off-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
> ---
>  Documentation/features/arch-support.txt |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/features/arch-support.txt b/Documentation/features/arch-support.txt
> index d22a109..f2b272e 100644
> --- a/Documentation/features/arch-support.txt
> +++ b/Documentation/features/arch-support.txt
> @@ -8,4 +8,5 @@ The meaning of entries in the tables is:
>      | ok |  # feature supported by the architecture
>      |TODO|  # feature not yet supported by the architecture
>      | .. |  # feature cannot be supported by the hardware
> +    | na |  # feature will not be supported by the architecture

"will not" sounds like someone's will. I guess it could be "feature is useless/needless
on the architecture".

Thank you,



-- 
Masami HIRAMATSU
Linux Technology Research Center, System Productivity Research Dept.
Center for Technology Innovation - Systems Engineering
Hitachi, Ltd., Research & Development Group
E-mail: masami.hiramatsu.pt@hitachi.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-07-19  5:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-17 10:51 [PATCH V2 1/2] Documentation/features: Add na key to arch-support.txt Ananth N Mavinakayanahalli
2015-07-17 10:52 ` [PATCH V2 2/2] kprobes: Mark OPTPROBES na for powerpc Ananth N Mavinakayanahalli
2015-07-19  5:21 ` [PATCH V2 1/2] Documentation/features: Add na key to arch-support.txt Masami Hiramatsu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).