From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
To: masami.hiramatsu.pt@hitachi.com, mpe@ellerman.id.au, mingo@kernel.org
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/2] kprobes: Mark OPTPROBES na for powerpc
Date: Mon, 20 Jul 2015 16:24:22 +0530 [thread overview]
Message-ID: <20150720105417.24801.66440.stgit@thinktux.in.ibm.com> (raw)
In-Reply-To: <20150720105349.24801.64387.stgit@thinktux.in.ibm.com>
Kprobes uses a breakpoint instruction to trap into execution flow
and the probed instruction is single-stepped from an alternate location.
On some architectures like x86, under certain conditions, the OPTPROBES
feature enables replacing the probed instruction with a jump instead,
resulting in a significant perfomance boost (both the breakpoint and
single-step exception is bypassed for each kprobe).
Powerpc has an in-kernel instruction emulator. Kprobes on powerpc uses
this emulator already and bypasses the single-step exception, with a
lot less complexity. There is a potential gain to be had with a direct
jump instead of a breakpoint, but the caveats need to be traded off
with the complexity it brings in.
For now, mark OPTPROBES na for powerpc.
Signed-off-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
---
.../features/debug/optprobes/arch-support.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/features/debug/optprobes/arch-support.txt b/Documentation/features/debug/optprobes/arch-support.txt
index b8999d8..73662f9 100644
--- a/Documentation/features/debug/optprobes/arch-support.txt
+++ b/Documentation/features/debug/optprobes/arch-support.txt
@@ -27,7 +27,7 @@
| nios2: | TODO |
| openrisc: | TODO |
| parisc: | TODO |
- | powerpc: | TODO |
+ | powerpc: | na |
| s390: | TODO |
| score: | TODO |
| sh: | TODO |
next prev parent reply other threads:[~2015-07-20 10:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 10:54 [PATCH V3 1/2] Documentation/features: Add na key to arch-support.txt Ananth N Mavinakayanahalli
2015-07-20 10:54 ` Ananth N Mavinakayanahalli [this message]
2015-07-20 13:41 ` [PATCH V3 2/2] kprobes: Mark OPTPROBES na for powerpc Segher Boessenkool
2015-07-21 5:50 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150720105417.24801.66440.stgit@thinktux.in.ibm.com \
--to=ananth@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).