From: David Miller <davem@davemloft.net>
To: chris.j.arges@canonical.com
Cc: nacc@linux.vnet.ibm.com, pshelar@nicira.com,
linuxppc-dev@lists.ozlabs.org, benh@kernel.crashing.org,
linux-numa@vger.kernel.org, netdev@vger.kernel.org,
dev@openvswitch.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] openvswitch: allocate nr_node_ids flow_stats instead of num_possible_nodes
Date: Tue, 21 Jul 2015 22:26:48 -0700 (PDT) [thread overview]
Message-ID: <20150721.222648.171655319967229139.davem@davemloft.net> (raw)
In-Reply-To: <1437500193-10255-1-git-send-email-chris.j.arges@canonical.com>
From: Chris J Arges <chris.j.arges@canonical.com>
Date: Tue, 21 Jul 2015 12:36:33 -0500
> Some architectures like POWER can have a NUMA node_possible_map that
> contains sparse entries. This causes memory corruption with openvswitch
> since it allocates flow_cache with a multiple of num_possible_nodes() and
> assumes the node variable returned by for_each_node will index into
> flow->stats[node].
>
> Use nr_node_ids to allocate a maximal sparse array instead of
> num_possible_nodes().
>
> The crash was noticed after 3af229f2 was applied as it changed the
> node_possible_map to match node_online_map on boot.
> Fixes: 3af229f2071f5b5cb31664be6109561fbe19c861
>
> Signed-off-by: Chris J Arges <chris.j.arges@canonical.com>
Applied, thanks.
prev parent reply other threads:[~2015-07-22 5:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 15:32 [PATCH] openvswitch: make for_each_node loops work with sparse numa systems Chris J Arges
2015-07-21 16:24 ` Nishanth Aravamudan
2015-07-21 16:30 ` Chris J Arges
2015-07-21 22:04 ` Nishanth Aravamudan
2015-07-21 17:36 ` [PATCH v2] openvswitch: allocate nr_node_ids flow_stats instead of num_possible_nodes Chris J Arges
2015-07-21 18:29 ` Pravin Shelar
2015-07-21 22:02 ` Nishanth Aravamudan
2015-07-22 5:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150721.222648.171655319967229139.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benh@kernel.crashing.org \
--cc=chris.j.arges@canonical.com \
--cc=dev@openvswitch.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-numa@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nacc@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).