From: Anton Blanchard <anton@samba.org>
To: Ian Munsie <imunsie@au1.ibm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@au1.ibm.com>,
linuxppc-dev <linuxppc-dev@ozlabs.org>,
Michael Neuling <michael.neuling@au1.ibm.com>,
"sonal.santan" <sonal.santan@xilinx.com>,
Jeremy Kerr <jk@ozlabs.org>,
Samuel Mendoza-Jonas <sam.mj@au1.ibm.com>
Subject: Re: [PATCH] Fix crash due to processing "memory-controller" nodes as "memory"
Date: Wed, 22 Jul 2015 15:15:02 +1000 [thread overview]
Message-ID: <20150722151502.15d557c4@kryten> (raw)
In-Reply-To: <1437525346-sup-7472@delenn.ozlabs.ibm.com>
Hi Ian,
> > > > Nice catch! I wonder if we should be checking for device_type
> > > > "memory". Ben?
> > >
> > > Yes. That's what Linux does.
> >
> > Ian: I made that change, and slightly modified your commit message.
> > Look ok?
>
> Looks good to me :)
Excellent, I just pushed the fix.
Anton
next prev parent reply other threads:[~2015-07-22 5:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 8:20 [PATCH] Fix crash due to processing "memory-controller" nodes as "memory" Ian Munsie
2015-07-20 8:25 ` Ian Munsie
2015-07-21 2:45 ` Anton Blanchard
2015-07-21 2:54 ` Benjamin Herrenschmidt
2015-07-21 3:06 ` Michael Ellerman
2015-07-21 23:18 ` Anton Blanchard
2015-07-22 0:36 ` Ian Munsie
2015-07-22 5:15 ` Anton Blanchard [this message]
2015-07-22 0:39 ` Jeremy Kerr
2015-07-22 1:32 ` Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150722151502.15d557c4@kryten \
--to=anton@samba.org \
--cc=benh@au1.ibm.com \
--cc=imunsie@au1.ibm.com \
--cc=jk@ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael.neuling@au1.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=sam.mj@au1.ibm.com \
--cc=sonal.santan@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).