From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 5248A1A0743 for ; Mon, 27 Jul 2015 17:31:36 +1000 (AEST) Received: by wicgb10 with SMTP id gb10so98921040wic.1 for ; Mon, 27 Jul 2015 00:31:32 -0700 (PDT) Date: Mon, 27 Jul 2015 10:31:29 +0300 From: "Kirill A. Shutemov" To: Eric B Munson Cc: Andrew Morton , Michal Hocko , Vlastimil Babka , Paul Gortmaker , Chris Metcalf , Guenter Roeck , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH V5 5/7] mm: mmap: Add mmap flag to request VM_LOCKONFAULT Message-ID: <20150727073129.GE11657@node.dhcp.inet.fi> References: <1437773325-8623-1-git-send-email-emunson@akamai.com> <1437773325-8623-6-git-send-email-emunson@akamai.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1437773325-8623-6-git-send-email-emunson@akamai.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Jul 24, 2015 at 05:28:43PM -0400, Eric B Munson wrote: > The cost of faulting in all memory to be locked can be very high when > working with large mappings. If only portions of the mapping will be > used this can incur a high penalty for locking. > > Now that we have the new VMA flag for the locked but not present state, > expose it as an mmap option like MAP_LOCKED -> VM_LOCKED. As I mentioned before, I don't think this interface is justified. MAP_LOCKED has known issues[1]. The MAP_LOCKED problem is not necessary affects MAP_LOCKONFAULT, but still. Let's not add new interface unless it's demonstrably useful. [1] http://lkml.kernel.org/g/20150114095019.GC4706@dhcp22.suse.cz -- Kirill A. Shutemov