From: Michael Ellerman <mpe@ellerman.id.au>
To: Luis Henriques <luis.henriques@canonical.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: macintosh/ans-lcd: fix build failure after module_init/exit relocation
Date: Fri, 31 Jul 2015 14:13:31 +1000 (AEST) [thread overview]
Message-ID: <20150731041332.09F9014031E@ozlabs.org> (raw)
In-Reply-To: <1437139231-11812-1-git-send-email-luis.henriques@canonical.com>
On Fri, 2015-17-07 at 13:20:31 UTC, Luis Henriques wrote:
> After commit 0fd972a7d91d ("module: relocate module_init from init.h to module.h")
> ans-lcd module fails to build with:
>
> drivers/macintosh/ans-lcd.c:201:1: warning: data definition has no type or storage class [enabled by default]
> module_init(anslcd_init);
> ^
> drivers/macintosh/ans-lcd.c:201:1: error: type defaults to 'int' in declaration of 'module_init' [-Werror=implicit-int]
> drivers/macintosh/ans-lcd.c:201:1: warning: parameter names (without types) in function declaration [enabled by default]
> drivers/macintosh/ans-lcd.c:202:1: warning: data definition has no type or storage class [enabled by default]
> module_exit(anslcd_exit);
> ^
> drivers/macintosh/ans-lcd.c:202:1: error: type defaults to 'int' in declaration of 'module_exit' [-Werror=implicit-int]
> drivers/macintosh/ans-lcd.c:202:1: warning: parameter names (without types) in function declaration [enabled by default]
> drivers/macintosh/ans-lcd.c:155:1: warning: 'anslcd_init' defined but not used [-Wunused-function]
> anslcd_init(void)
> ^
> drivers/macintosh/ans-lcd.c:195:1: warning: 'anslcd_exit' defined but not used [-Wunused-function]
> anslcd_exit(void)
> ^
>
> This commit fixes it by replacing linux/init.h by linux/module.h.
>
> Fixes: 0fd972a7d91d ("module: relocate module_init from init.h to module.h")
> Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
> Acked-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/120d200a86273d1840d0
cheers
prev parent reply other threads:[~2015-07-31 4:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 13:20 [PATCH] macintosh/ans-lcd: fix build failure after module_init/exit relocation Luis Henriques
2015-07-18 23:45 ` Paul Gortmaker
2015-07-20 9:06 ` Luis Henriques
2015-07-31 4:13 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150731041332.09F9014031E@ozlabs.org \
--to=mpe@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luis.henriques@canonical.com \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).