* [PATCH] powerpc/eeh-powernv: Fix unbalanced IRQ warning
@ 2015-07-30 6:53 Alistair Popple
2015-07-31 4:13 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Alistair Popple @ 2015-07-30 6:53 UTC (permalink / raw)
To: mpe; +Cc: linuxppc-dev, dja, gwshan, Alistair Popple
pnv_eeh_next_error() re-enables the eeh opal event interrupt but it
gets called from a loop if there are more outstanding events to
process, resulting in a warning due to enabling an already enabled
interrupt. Instead the interrupt should only be re-enabled once the
last outstanding event has been processed.
Tested-by: Daniel Axtens <dja@axtens.net>
Reported-by: Daniel Axtens <dja@axtens.net>
Signed-off-by: Alistair Popple <alistair@popple.id.au>
Acked-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
---
arch/powerpc/platforms/powernv/eeh-powernv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/powernv/eeh-powernv.c b/arch/powerpc/platforms/powernv/eeh-powernv.c
index ca825ec..ff41c03 100644
--- a/arch/powerpc/platforms/powernv/eeh-powernv.c
+++ b/arch/powerpc/platforms/powernv/eeh-powernv.c
@@ -1478,7 +1478,7 @@ static int pnv_eeh_next_error(struct eeh_pe **pe)
}
/* Unmask the event */
- if (eeh_enabled())
+ if (ret == EEH_NEXT_ERR_NONE && eeh_enabled())
enable_irq(eeh_event_irq);
return ret;
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: powerpc/eeh-powernv: Fix unbalanced IRQ warning
2015-07-30 6:53 [PATCH] powerpc/eeh-powernv: Fix unbalanced IRQ warning Alistair Popple
@ 2015-07-31 4:13 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2015-07-31 4:13 UTC (permalink / raw)
To: Alistair Popple; +Cc: Alistair Popple, linuxppc-dev, gwshan, dja
On Thu, 2015-30-07 at 06:53:54 UTC, Alistair Popple wrote:
> pnv_eeh_next_error() re-enables the eeh opal event interrupt but it
> gets called from a loop if there are more outstanding events to
> process, resulting in a warning due to enabling an already enabled
> interrupt. Instead the interrupt should only be re-enabled once the
> last outstanding event has been processed.
>
> Tested-by: Daniel Axtens <dja@axtens.net>
> Reported-by: Daniel Axtens <dja@axtens.net>
> Signed-off-by: Alistair Popple <alistair@popple.id.au>
> Acked-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/b8d65e9662b1ffb3b52a
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-31 4:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-30 6:53 [PATCH] powerpc/eeh-powernv: Fix unbalanced IRQ warning Alistair Popple
2015-07-31 4:13 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).