[PATCH 1/2] powerpc/config: enable teranetics PHY

[PATCH 1/2] powerpc/config: enable teranetics PHY

[shh.xie]

From: Shaohui Xie <Shaohui.Xie@freescale.com>

The PHY uses XAUI interface to connect to MAC, mostly the PHY used on
riser card.

Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
---
 arch/powerpc/configs/corenet32_smp_defconfig | 1 +
 arch/powerpc/configs/corenet64_smp_defconfig | 1 +
 2 files changed, 2 insertions(+)

diff --git a/arch/powerpc/configs/corenet32_smp_defconfig b/arch/powerpc/configs/corenet32_smp_defconfig
index 3765993..fe77d60 100644
--- a/arch/powerpc/configs/corenet32_smp_defconfig
+++ b/arch/powerpc/configs/corenet32_smp_defconfig
@@ -97,6 +97,7 @@ CONFIG_FSL_XGMAC_MDIO=y
 CONFIG_E1000=y
 CONFIG_E1000E=y
 CONFIG_AT803X_PHY=y
+CONFIG_TERANETICS_PHY=y
 CONFIG_VITESSE_PHY=y
 CONFIG_FIXED_PHY=y
 CONFIG_MDIO_BUS_MUX_GPIO=y
diff --git a/arch/powerpc/configs/corenet64_smp_defconfig b/arch/powerpc/configs/corenet64_smp_defconfig
index 33cd1df..3c5b5ac 100644
--- a/arch/powerpc/configs/corenet64_smp_defconfig
+++ b/arch/powerpc/configs/corenet64_smp_defconfig
@@ -91,6 +91,7 @@ CONFIG_DUMMY=y
 CONFIG_FSL_PQ_MDIO=y
 CONFIG_FSL_XGMAC_MDIO=y
 CONFIG_E1000E=y
+CONFIG_TERANETICS_PHY=y
 CONFIG_VITESSE_PHY=y
 CONFIG_FIXED_PHY=y
 CONFIG_MDIO_BUS_MUX_GPIO=y
-- 
1.8.4.1

Re: [1/2] powerpc/config: enable teranetics PHY

[Scott Wood]

On Fri, Jul 24, 2015 at 11:45:33AM +0800, shaohui xie wrote:
> From: Shaohui Xie <Shaohui.Xie@freescale.com>
> 
> The PHY uses XAUI interface to connect to MAC, mostly the PHY used on
> riser card.
> 
> Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> ---
>  arch/powerpc/configs/corenet32_smp_defconfig | 1 +
>  arch/powerpc/configs/corenet64_smp_defconfig | 1 +
>  2 files changed, 2 insertions(+)

Next time, please use a subject line that lets me know that this is a
patch that I'd be picking up, such as "powerpc/85xx: ..." or
"powerpc/corenet: ..."

-Scott

Re: [1/2] powerpc/config: enable teranetics PHY

[Scott Wood]

On Tue, 2015-08-04 at 19:18 -0500, Scott Wood wrote:
> On Fri, Jul 24, 2015 at 11:45:33AM +0800, shaohui xie wrote:
> > From: Shaohui Xie <Shaohui.Xie@freescale.com>
> > 
> > The PHY uses XAUI interface to connect to MAC, mostly the PHY used on
> > riser card.
> > 
> > Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> > ---
> >  arch/powerpc/configs/corenet32_smp_defconfig | 1 +
> >  arch/powerpc/configs/corenet64_smp_defconfig | 1 +
> >  2 files changed, 2 insertions(+)
> 
> Next time, please use a subject line that lets me know that this is a
> patch that I'd be picking up, such as "powerpc/85xx: ..." or
> "powerpc/corenet: ..."

More importantly, don't send patches to enable config options that don't 
exist.

-Scott

Re: [1/2] powerpc/config: enable teranetics PHY

[Scott Wood]

On Tue, 2015-08-04 at 19:24 -0500, Scott Wood wrote:
> On Tue, 2015-08-04 at 19:18 -0500, Scott Wood wrote:
> > On Fri, Jul 24, 2015 at 11:45:33AM +0800, shaohui xie wrote:
> > > From: Shaohui Xie <Shaohui.Xie@freescale.com>
> > > 
> > > The PHY uses XAUI interface to connect to MAC, mostly the PHY used on
> > > riser card.
> > > 
> > > Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> > > ---
> > >  arch/powerpc/configs/corenet32_smp_defconfig | 1 +
> > >  arch/powerpc/configs/corenet64_smp_defconfig | 1 +
> > >  2 files changed, 2 insertions(+)
> > 
> > Next time, please use a subject line that lets me know that this is a
> > patch that I'd be picking up, such as "powerpc/85xx: ..." or
> > "powerpc/corenet: ..."
> 
> More importantly, don't send patches to enable config options that don't 
> exist.

Sorry, this comment was meant for patch 2/2 (CONFIG_AQUANTIA_PHY).  
CONFIG_TERANETICS_PHY does exist in linux-next (that it depends on a patch in 
linux-next should be mentioned below the ---).

-Scott

RE: [1/2] powerpc/config: enable teranetics PHY

[Shaohui Xie]

PiBPbiBUdWUsIDIwMTUtMDgtMDQgYXQgMTk6MjQgLTA1MDAsIFNjb3R0IFdvb2Qgd3JvdGU6DQo+
ID4gT24gVHVlLCAyMDE1LTA4LTA0IGF0IDE5OjE4IC0wNTAwLCBTY290dCBXb29kIHdyb3RlOg0K
PiA+ID4gT24gRnJpLCBKdWwgMjQsIDIwMTUgYXQgMTE6NDU6MzNBTSArMDgwMCwgc2hhb2h1aSB4
aWUgd3JvdGU6DQo+ID4gPiA+IEZyb206IFNoYW9odWkgWGllIDxTaGFvaHVpLlhpZUBmcmVlc2Nh
bGUuY29tPg0KPiA+ID4gPg0KPiA+ID4gPiBUaGUgUEhZIHVzZXMgWEFVSSBpbnRlcmZhY2UgdG8g
Y29ubmVjdCB0byBNQUMsIG1vc3RseSB0aGUgUEhZIHVzZWQNCj4gPiA+ID4gb24gcmlzZXIgY2Fy
ZC4NCj4gPiA+ID4NCj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogU2hhb2h1aSBYaWUgPFNoYW9odWku
WGllQGZyZWVzY2FsZS5jb20+DQo+ID4gPiA+IC0tLQ0KPiA+ID4gPiAgYXJjaC9wb3dlcnBjL2Nv
bmZpZ3MvY29yZW5ldDMyX3NtcF9kZWZjb25maWcgfCAxICsNCj4gPiA+ID4gYXJjaC9wb3dlcnBj
L2NvbmZpZ3MvY29yZW5ldDY0X3NtcF9kZWZjb25maWcgfCAxICsNCj4gPiA+ID4gIDIgZmlsZXMg
Y2hhbmdlZCwgMiBpbnNlcnRpb25zKCspDQo+ID4gPg0KPiA+ID4gTmV4dCB0aW1lLCBwbGVhc2Ug
dXNlIGEgc3ViamVjdCBsaW5lIHRoYXQgbGV0cyBtZSBrbm93IHRoYXQgdGhpcyBpcw0KPiA+ID4g
YSBwYXRjaCB0aGF0IEknZCBiZSBwaWNraW5nIHVwLCBzdWNoIGFzICJwb3dlcnBjLzg1eHg6IC4u
LiIgb3INCj4gPiA+ICJwb3dlcnBjL2NvcmVuZXQ6IC4uLiINCj4gPg0KPiA+IE1vcmUgaW1wb3J0
YW50bHksIGRvbid0IHNlbmQgcGF0Y2hlcyB0byBlbmFibGUgY29uZmlnIG9wdGlvbnMgdGhhdA0K
PiA+IGRvbid0IGV4aXN0Lg0KPiANCj4gU29ycnksIHRoaXMgY29tbWVudCB3YXMgbWVhbnQgZm9y
IHBhdGNoIDIvMiAoQ09ORklHX0FRVUFOVElBX1BIWSkuDQo+IENPTkZJR19URVJBTkVUSUNTX1BI
WSBkb2VzIGV4aXN0IGluIGxpbnV4LW5leHQgKHRoYXQgaXQgZGVwZW5kcyBvbiBhDQo+IHBhdGNo
IGluIGxpbnV4LW5leHQgc2hvdWxkIGJlIG1lbnRpb25lZCBiZWxvdyB0aGUgLS0tKS4NCkhpIFNj
b3R0LA0KDQpUaGUgQ09ORklHX0FRVUFOVElBX1BIWSB3YXMgYWRkZWQgaW4gYW5vdGhlciBwYXRj
aCBzZW50IHRvIG5ldC1uZXh0LCANCml0IHdhcyBub3QgYWNjZXB0ZWQgd2hlbiBJIHNlbnQgdGhl
IHBhdGNoIHRvIGVuYWJsZSB0aGlzIGNvbmZpZywNCmxhdGVyIHRoZSBwYXRjaCB3YXMgYWNjZXB0
ZWQgaW4gbmV0LW5leHQsDQpodHRwczovL2dpdC5rZXJuZWwub3JnL2NnaXQvbGludXgva2VybmVs
L2dpdC9kYXZlbS9uZXQtbmV4dC5naXQvY29tbWl0Lz9pZD1iZWU4MjU5ZGQzMWY0MTlhODgzMTc0
NTU2YjExZWRjNmY5YTE1M2QxDQoNCkkgc2hvdWxkIG1lbnRpb24gdGhpcyBiZWxvdyB0aGUgLS0t
Lg0KU29ycnkhDQoNClNob3VsZCBJIHJlLXNlbmQgdGhlIHBhdGNoIG9mIGVuYWJsaW5nIGNvbmZp
ZyBvcHRpb24gb2YgQ09ORklHX0FRVUFOVElBX1BIWT8NCg0KVGhhbmtzIQ0KU2hhb2h1aQ0KDQo=

RE: [1/2] powerpc/config: enable teranetics PHY

[Shaohui Xie]

PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBYaWUgU2hhb2h1aS1CMjE5ODkN
Cj4gU2VudDogV2VkbmVzZGF5LCBBdWd1c3QgMDUsIDIwMTUgMTE6MDAgQU0NCj4gVG86IFdvb2Qg
U2NvdHQtQjA3NDIxDQo+IENjOiBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZw0KPiBTdWJq
ZWN0OiBSRTogWzEvMl0gcG93ZXJwYy9jb25maWc6IGVuYWJsZSB0ZXJhbmV0aWNzIFBIWQ0KPiAN
Cj4gPiBPbiBUdWUsIDIwMTUtMDgtMDQgYXQgMTk6MjQgLTA1MDAsIFNjb3R0IFdvb2Qgd3JvdGU6
DQo+ID4gPiBPbiBUdWUsIDIwMTUtMDgtMDQgYXQgMTk6MTggLTA1MDAsIFNjb3R0IFdvb2Qgd3Jv
dGU6DQo+ID4gPiA+IE9uIEZyaSwgSnVsIDI0LCAyMDE1IGF0IDExOjQ1OjMzQU0gKzA4MDAsIHNo
YW9odWkgeGllIHdyb3RlOg0KPiA+ID4gPiA+IEZyb206IFNoYW9odWkgWGllIDxTaGFvaHVpLlhp
ZUBmcmVlc2NhbGUuY29tPg0KPiA+ID4gPiA+DQo+ID4gPiA+ID4gVGhlIFBIWSB1c2VzIFhBVUkg
aW50ZXJmYWNlIHRvIGNvbm5lY3QgdG8gTUFDLCBtb3N0bHkgdGhlIFBIWQ0KPiA+ID4gPiA+IHVz
ZWQgb24gcmlzZXIgY2FyZC4NCj4gPiA+ID4gPg0KPiA+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IFNo
YW9odWkgWGllIDxTaGFvaHVpLlhpZUBmcmVlc2NhbGUuY29tPg0KPiA+ID4gPiA+IC0tLQ0KPiA+
ID4gPiA+ICBhcmNoL3Bvd2VycGMvY29uZmlncy9jb3JlbmV0MzJfc21wX2RlZmNvbmZpZyB8IDEg
Kw0KPiA+ID4gPiA+IGFyY2gvcG93ZXJwYy9jb25maWdzL2NvcmVuZXQ2NF9zbXBfZGVmY29uZmln
IHwgMSArDQo+ID4gPiA+ID4gIDIgZmlsZXMgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspDQo+ID4g
PiA+DQo+ID4gPiA+IE5leHQgdGltZSwgcGxlYXNlIHVzZSBhIHN1YmplY3QgbGluZSB0aGF0IGxl
dHMgbWUga25vdyB0aGF0IHRoaXMNCj4gPiA+ID4gaXMgYSBwYXRjaCB0aGF0IEknZCBiZSBwaWNr
aW5nIHVwLCBzdWNoIGFzICJwb3dlcnBjLzg1eHg6IC4uLiIgb3INCj4gPiA+ID4gInBvd2VycGMv
Y29yZW5ldDogLi4uIg0KPiA+ID4NCj4gPiA+IE1vcmUgaW1wb3J0YW50bHksIGRvbid0IHNlbmQg
cGF0Y2hlcyB0byBlbmFibGUgY29uZmlnIG9wdGlvbnMgdGhhdA0KPiA+ID4gZG9uJ3QgZXhpc3Qu
DQo+ID4NCj4gPiBTb3JyeSwgdGhpcyBjb21tZW50IHdhcyBtZWFudCBmb3IgcGF0Y2ggMi8yIChD
T05GSUdfQVFVQU5USUFfUEhZKS4NCj4gPiBDT05GSUdfVEVSQU5FVElDU19QSFkgZG9lcyBleGlz
dCBpbiBsaW51eC1uZXh0ICh0aGF0IGl0IGRlcGVuZHMgb24gYQ0KPiA+IHBhdGNoIGluIGxpbnV4
LW5leHQgc2hvdWxkIGJlIG1lbnRpb25lZCBiZWxvdyB0aGUgLS0tKS4NCj4gSGkgU2NvdHQsDQo+
IA0KPiBUaGUgQ09ORklHX0FRVUFOVElBX1BIWSB3YXMgYWRkZWQgaW4gYW5vdGhlciBwYXRjaCBz
ZW50IHRvIG5ldC1uZXh0LCBpdA0KPiB3YXMgbm90IGFjY2VwdGVkIHdoZW4gSSBzZW50IHRoZSBw
YXRjaCB0byBlbmFibGUgdGhpcyBjb25maWcsIGxhdGVyIHRoZQ0KPiBwYXRjaCB3YXMgYWNjZXB0
ZWQgaW4gbmV0LW5leHQsDQo+IGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvY2dpdC9saW51eC9rZXJu
ZWwvZ2l0L2RhdmVtL25ldC0NCj4gbmV4dC5naXQvY29tbWl0Lz9pZD1iZWU4MjU5ZGQzMWY0MTlh
ODgzMTc0NTU2YjExZWRjNmY5YTE1M2QxDQpbUy5IXSBKdXN0IGZvdW5kIHRoZSBwYXRjaCB3YXMg
YWxzbyBtZXJnZWQgaW4gTGludXgtbmV4dDoNCmh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvY2dpdC9s
aW51eC9rZXJuZWwvZ2l0L25leHQvbGludXgtbmV4dC5naXQvY29tbWl0Lz9pZD1iZWU4MjU5ZGQz
MWY0MTlhODgzMTc0NTU2YjExZWRjNmY5YTE1M2QxDQoNClRoYW5rcy4NClNoYW9odWkNCj4gDQo+
IEkgc2hvdWxkIG1lbnRpb24gdGhpcyBiZWxvdyB0aGUgLS0tLg0KPiBTb3JyeSENCj4gDQo+IFNo
b3VsZCBJIHJlLXNlbmQgdGhlIHBhdGNoIG9mIGVuYWJsaW5nIGNvbmZpZyBvcHRpb24gb2YNCj4g
Q09ORklHX0FRVUFOVElBX1BIWT8NCj4gDQo+IFRoYW5rcyENCj4gU2hhb2h1aQ0KDQo=

RE: [1/2] powerpc/config: enable teranetics PHY

[Shaohui Xie]

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Wednesday, August 05, 2015 8:19 AM
> To: shaohui xie
> Cc: linuxppc-dev@lists.ozlabs.org; Xie Shaohui-B21989
> Subject: Re: [1/2] powerpc/config: enable teranetics PHY
>=20
> On Fri, Jul 24, 2015 at 11:45:33AM +0800, shaohui xie wrote:
> > From: Shaohui Xie <Shaohui.Xie@freescale.com>
> >
> > The PHY uses XAUI interface to connect to MAC, mostly the PHY used on
> > riser card.
> >
> > Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> > ---
> >  arch/powerpc/configs/corenet32_smp_defconfig | 1 +
> > arch/powerpc/configs/corenet64_smp_defconfig | 1 +
> >  2 files changed, 2 insertions(+)
>=20
> Next time, please use a subject line that lets me know that this is a
> patch that I'd be picking up, such as "powerpc/85xx: ..." or
> "powerpc/corenet: ..."
OK.
Sorry for the inconvenience.

Thanks.
Shaohui

Re: [1/2] powerpc/config: enable teranetics PHY

[Scott Wood]

On Tue, 2015-08-04 at 22:06 -0500, Xie Shaohui-B21989 wrote:
> > -----Original Message-----
> > From: Xie Shaohui-B21989
> > Sent: Wednesday, August 05, 2015 11:00 AM
> > To: Wood Scott-B07421
> > Cc: linuxppc-dev@lists.ozlabs.org
> > Subject: RE: [1/2] powerpc/config: enable teranetics PHY
> > 
> > > On Tue, 2015-08-04 at 19:24 -0500, Scott Wood wrote:
> > > > On Tue, 2015-08-04 at 19:18 -0500, Scott Wood wrote:
> > > > > On Fri, Jul 24, 2015 at 11:45:33AM +0800, shaohui xie wrote:
> > > > > > From: Shaohui Xie <Shaohui.Xie@freescale.com>
> > > > > > 
> > > > > > The PHY uses XAUI interface to connect to MAC, mostly the PHY
> > > > > > used on riser card.
> > > > > > 
> > > > > > Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> > > > > > ---
> > > > > >  arch/powerpc/configs/corenet32_smp_defconfig | 1 +
> > > > > > arch/powerpc/configs/corenet64_smp_defconfig | 1 +
> > > > > >  2 files changed, 2 insertions(+)
> > > > > 
> > > > > Next time, please use a subject line that lets me know that this
> > > > > is a patch that I'd be picking up, such as "powerpc/85xx: ..." or
> > > > > "powerpc/corenet: ..."
> > > > 
> > > > More importantly, don't send patches to enable config options that
> > > > don't exist.
> > > 
> > > Sorry, this comment was meant for patch 2/2 (CONFIG_AQUANTIA_PHY).
> > > CONFIG_TERANETICS_PHY does exist in linux-next (that it depends on a
> > > patch in linux-next should be mentioned below the ---).
> > Hi Scott,
> > 
> > The CONFIG_AQUANTIA_PHY was added in another patch sent to net-next, it
> > was not accepted when I sent the patch to enable this config, later the
> > patch was accepted in net-next,
> > https://git.kernel.org/cgit/linux/kernel/git/davem/net-
> > next.git/commit/?id=bee8259dd31f419a883174556b11edc6f9a153d1
> [S.H] Just found the patch was also merged in Linux-next:
> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=bee8259dd31f419a883174556b11edc6f9a153d1

OK, thanks for letting me know.  I must have been looking at a linux-next 
that I fetched before that.  No need to resend, just next time let me know 
about the dependency.

-Scott