From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 8E4971A1D2A for ; Thu, 6 Aug 2015 23:49:22 +1000 (AEST) Received: from e28smtp08.in.ibm.com (e28smtp08.in.ibm.com [122.248.162.8]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id DDD4D1402B9 for ; Thu, 6 Aug 2015 23:49:21 +1000 (AEST) Received: from /spool/local by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 6 Aug 2015 19:19:19 +0530 Received: from d28relay04.in.ibm.com (d28relay04.in.ibm.com [9.184.220.61]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id 9E57CE005F for ; Thu, 6 Aug 2015 19:23:31 +0530 (IST) Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63]) by d28relay04.in.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t76Dn4Mf16646366 for ; Thu, 6 Aug 2015 19:19:06 +0530 Received: from d28av01.in.ibm.com (localhost [127.0.0.1]) by d28av01.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t76Dn4uk025743 for ; Thu, 6 Aug 2015 19:19:04 +0530 Date: Thu, 6 Aug 2015 21:49:02 +0800 From: Wei Yang To: Gavin Shan Cc: Wei Yang , aik@ozlabs.ru, benh@kernel.crashing.org, linuxppc-dev@ozlabs.org Subject: Re: [PATCH V2 2/6] powerpc/powernv: simplify the calculation of iov resource Message-ID: <20150806134901.GB6235@richard> Reply-To: Wei Yang References: <20150731020148.GA6151@richard> <1438737903-10399-1-git-send-email-weiyang@linux.vnet.ibm.com> <1438737903-10399-3-git-send-email-weiyang@linux.vnet.ibm.com> <20150806045139.GB28524@gwshan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20150806045139.GB28524@gwshan> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Aug 06, 2015 at 02:51:40PM +1000, Gavin Shan wrote: >On Wed, Aug 05, 2015 at 09:24:59AM +0800, Wei Yang wrote: >>The alignment of IOV BAR on PowerNV platform is the total size of the IOV >>BAR. No matter whether the IOV BAR is truncated or not, the total size >>could be calculated by (vfs_expanded * VF size). >> > >s/VF size/VF BAR size > >I think the changelog would be more explicit: > >The alignment of IOV BAR on PowerNV platform is the total size of the >IOV BAR, no matter whether the IOV BAR is extended with number of max >VFs or number of max PE number (256). The alignment can be calculated number of max VFs is not correct. This should be roundup_pow_of_two(total_vfs). Others looks good to me. >by (vfs_expaned * VF_BAR_size). > >>This patch simplifies the pnv_pci_iov_resource_alignment() by removing the >>first case. >> >>Signed-off-by: Wei Yang > >Reviewed-by: Gavin Shan > >>--- >> arch/powerpc/platforms/powernv/pci-ioda.c | 14 +++++++++----- >> 1 file changed, 9 insertions(+), 5 deletions(-) >> >>diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c >>index 9b41dba..7192e62 100644 >>--- a/arch/powerpc/platforms/powernv/pci-ioda.c >>+++ b/arch/powerpc/platforms/powernv/pci-ioda.c >>@@ -2987,12 +2987,16 @@ static resource_size_t pnv_pci_iov_resource_alignment(struct pci_dev *pdev, >> int resno) >> { >> struct pci_dn *pdn = pci_get_pdn(pdev); >>- resource_size_t align, iov_align; >>- >>- iov_align = resource_size(&pdev->resource[resno]); >>- if (iov_align) >>- return iov_align; >>+ resource_size_t align; >> >>+ /* >>+ * On PowerNV platform, IOV BAR is mapped by M64 BAR to enable the >>+ * SR-IOV. While from hardware perspective, the range mapped by M64 >>+ * BAR should be size aligned. >>+ * >>+ * This function return the total IOV BAR size if expanded or just the >>+ * individual size if not. >>+ */ >> align = pci_iov_resource_size(pdev, resno); >> if (pdn->vfs_expanded) >> return pdn->vfs_expanded * align; >>-- >>1.7.9.5 >> -- Richard Yang Help you, Help me