From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id D34241A1DC7 for ; Fri, 14 Aug 2015 13:40:40 +1000 (AEST) Received: from e23smtp09.au.ibm.com (e23smtp09.au.ibm.com [202.81.31.142]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 5D52A14018C for ; Fri, 14 Aug 2015 13:40:40 +1000 (AEST) Received: from /spool/local by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 14 Aug 2015 13:40:38 +1000 Received: from d23relay07.au.ibm.com (d23relay07.au.ibm.com [9.190.26.37]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 597642BB0051 for ; Fri, 14 Aug 2015 13:40:35 +1000 (EST) Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay07.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t7E3eSfi41812210 for ; Fri, 14 Aug 2015 13:40:36 +1000 Received: from d23av02.au.ibm.com (localhost [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t7E3e2bF024565 for ; Fri, 14 Aug 2015 13:40:02 +1000 Date: Fri, 14 Aug 2015 11:39:44 +0800 From: Wei Yang To: Gavin Shan Cc: Wei Yang , aik@ozlabs.ru, benh@kernel.crashing.org, linuxppc-dev@ozlabs.org Subject: Re: [PATCH v3 2/6] powerpc/powernv: simplify the calculation of iov resource alignment Message-ID: <20150814033944.GA11381@richard> Reply-To: Wei Yang References: <1439475071-7001-1-git-send-email-weiyang@linux.vnet.ibm.com> <1439475071-7001-3-git-send-email-weiyang@linux.vnet.ibm.com> <20150814010458.GA19889@gwshan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20150814010458.GA19889@gwshan> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Aug 14, 2015 at 11:04:58AM +1000, Gavin Shan wrote: >On Thu, Aug 13, 2015 at 10:11:07PM +0800, Wei Yang wrote: >>The alignment of IOV BAR on PowerNV platform is the total size of the IOV >>BAR. No matter whether the IOV BAR is extended with number of >>roundup_pow_of_two(total_vfs) or number of max PE number (256), the total >>size could be calculated by (vfs_expanded * VF_BAR_size). >> >>This patch simplifies the pnv_pci_iov_resource_alignment() by removing the >>first case. >> >>Signed-off-by: Wei Yang >>Reviewed-by: Gavin Shan >>--- >> arch/powerpc/platforms/powernv/pci-ioda.c | 14 +++++++++----- >> 1 file changed, 9 insertions(+), 5 deletions(-) >> >>diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c >>index 9ac324e..67b8f72 100644 >>--- a/arch/powerpc/platforms/powernv/pci-ioda.c >>+++ b/arch/powerpc/platforms/powernv/pci-ioda.c >>@@ -2987,12 +2987,16 @@ static resource_size_t pnv_pci_iov_resource_alignment(struct pci_dev *pdev, >> int resno) >> { >> struct pci_dn *pdn = pci_get_pdn(pdev); >>- resource_size_t align, iov_align; >>- >>- iov_align = resource_size(&pdev->resource[resno]); >>- if (iov_align) >>- return iov_align; >>+ resource_size_t align; >> >>+ /* >>+ * On PowerNV platform, IOV BAR is mapped by M64 BAR to enable the >>+ * SR-IOV. While from hardware perspective, the range mapped by M64 >>+ * BAR should be size aligned. >>+ * >>+ * This function return the total IOV BAR size if expanded or just the >>+ * individual size if not. >>+ */ > >s/return/returns > Thanks :-) >> align = pci_iov_resource_size(pdev, resno); >> if (pdn->vfs_expanded) >> return pdn->vfs_expanded * align; >>-- >>1.7.9.5 >> -- Richard Yang Help you, Help me