From: Michael Ellerman <mpe@ellerman.id.au>
To: Andrew Donnellan <andrew.donnellan@au1.ibm.com>, linuxppc-dev@ozlabs.org
Cc: mikey@neuling.org, imunsie@au1.ibm.com,
Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
dja@axtens.net
Subject: Re: [V2] cxl: Allow release of contexts which have been OPENED but not STARTED
Date: Thu, 20 Aug 2015 18:38:11 +1000 (AEST) [thread overview]
Message-ID: <20150820083812.01673140293@ozlabs.org> (raw)
In-Reply-To: <1439940438-3585-1-git-send-email-andrew.donnellan@au1.ibm.com>
On Tue, 2015-18-08 at 23:27:18 UTC, Andrew Donnellan wrote:
> If we open a context but do not start it (either because we do not attempt
> to start it, or because it fails to start for some reason), we are left
> with a context in state OPENED. Previously, cxl_release_context() only
> allowed releasing contexts in state CLOSED, so attempting to release an
> OPENED context would fail.
>
> In particular, this bug causes available contexts to run out after some EEH
> failures, where drivers attempt to release contexts that have failed to
> start.
>
> Allow releasing contexts in any state with a value lower than STARTED, i.e.
> OPENED or CLOSED (we can't release a STARTED context as it's currently
> using the hardware, and we assume that contexts in any new states which may
> be added in future with a value higher than STARTED are also unsafe to
> release).
>
> Cc: stable@vger.kernel.org
> Fixes: 6f7f0b3df6d4 ("cxl: Add AFU virtual PHB and kernel API")
> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> Signed-off-by: Daniel Axtens <dja@axtens.net>
> Acked-by: Ian Munsie <imunsie@au1.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/7c26b9cf5347c2427215
cheers
prev parent reply other threads:[~2015-08-20 8:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 23:27 [PATCH V2] cxl: Allow release of contexts which have been OPENED but not STARTED Andrew Donnellan
2015-08-18 23:52 ` Ian Munsie
2015-08-20 8:38 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150820083812.01673140293@ozlabs.org \
--to=mpe@ellerman.id.au \
--cc=andrew.donnellan@au1.ibm.com \
--cc=dja@axtens.net \
--cc=imunsie@au1.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).