From: Michael Ellerman <mpe@ellerman.id.au>
To: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>,
linux-leds@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Cc: stewart@linux.vnet.ibm.com, j.anaszewski81@gmail.com,
arnd@arndb.de, cooloney@gmail.com,
Vasant Hegde <hegdevasant@linux.vnet.ibm.com>,
rpurdie@rpsys.net, j.anaszewski@samsung.com,
khandual@linux.vnet.ibm.com
Subject: Re: [v10,3/3] leds/powernv: Add driver for PowerNV platform
Date: Thu, 20 Aug 2015 18:38:12 +1000 (AEST) [thread overview]
Message-ID: <20150820083812.88640140297@ozlabs.org> (raw)
In-Reply-To: <1440002994-25662-4-git-send-email-hegdevasant@linux.vnet.ibm.com>
On Wed, 2015-19-08 at 16:49:54 UTC, Vasant Hegde wrote:
> This patch implements LED driver for PowerNV platform using the existing
> generic LED class framework.
>
> PowerNV platform has below type of LEDs:
> - System attention
> Indicates there is a problem with the system that needs attention.
> - Identify
> Helps the user locate/identify a particular FRU or resource in the
> system.
> - Fault
> Indicates there is a problem with the FRU or resource at the
> location with which the indicator is associated.
>
> We register classdev structures for all individual LEDs detected on the
> system through LED specific device tree nodes. Device tree nodes specify
> what all kind of LEDs present on the same location code. It registers
> LED classdev structure for each of them.
>
> All the system LEDs can be found in the same regular path /sys/class/leds/.
> We don't use LED colors. We use LED node and led-types property to form
> LED classdev. Our LEDs have names in this format.
>
> <location_code>:<attention|identify|fault>
>
> Any positive brightness value would turn on the LED and a zero value would
> turn off the LED. The driver will return LED_FULL (255) for any turned on
> LED and LED_OFF (0) for any turned off LED.
>
> The platform level implementation of LED get and set state has been
> achieved through OPAL calls. These calls are made available for the
> driver by exporting from architecture specific codes.
>
> Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
> Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>
> Acked-by: Stewart Smith <stewart@linux.vnet.ibm.com>
> Tested-by: Stewart Smith <stewart@linux.vnet.ibm.com>
> Acked-by: Jacek Anaszewski <j.anaszewski@samsung.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/84ad6e5cd3e8b365c893
cheers
prev parent reply other threads:[~2015-08-20 8:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 16:49 [PATCH v10 0/3] LED driver for PowerNV platform Vasant Hegde
2015-08-19 16:49 ` [PATCH v10 1/3] powerpc/powernv: Add OPAL interfaces for accessing and modifying system LED states Vasant Hegde
2015-08-20 8:38 ` [v10, " Michael Ellerman
2015-08-19 16:49 ` [PATCH v10 2/3] powerpc/powernv: Create LED platform device Vasant Hegde
2015-08-20 8:38 ` [v10,2/3] " Michael Ellerman
2015-08-19 16:49 ` [PATCH v10 3/3] leds/powernv: Add driver for PowerNV platform Vasant Hegde
2015-08-20 8:38 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150820083812.88640140297@ozlabs.org \
--to=mpe@ellerman.id.au \
--cc=arnd@arndb.de \
--cc=cooloney@gmail.com \
--cc=hegdevasant@linux.vnet.ibm.com \
--cc=j.anaszewski81@gmail.com \
--cc=j.anaszewski@samsung.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-leds@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rpurdie@rpsys.net \
--cc=stewart@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).