From: Ingo Molnar <mingo@kernel.org>
To: Kevin Hao <haokexin@gmail.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 3/8] jump_label: introduce DEFINE_STATIC_KEY_{TRUE,FALSE}_ARRAY macros
Date: Fri, 21 Aug 2015 08:28:26 +0200 [thread overview]
Message-ID: <20150821062826.GA566@gmail.com> (raw)
In-Reply-To: <1440072876-8321-4-git-send-email-haokexin@gmail.com>
* Kevin Hao <haokexin@gmail.com> wrote:
> These are used to define a static_key_{true,false} array.
>
> Signed-off-by: Kevin Hao <haokexin@gmail.com>
> ---
> include/linux/jump_label.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/linux/jump_label.h b/include/linux/jump_label.h
> index 7f653e8f6690..5c1d6a49dd6b 100644
> --- a/include/linux/jump_label.h
> +++ b/include/linux/jump_label.h
> @@ -267,6 +267,12 @@ struct static_key_false {
> #define DEFINE_STATIC_KEY_FALSE(name) \
> struct static_key_false name = STATIC_KEY_FALSE_INIT
>
> +#define DEFINE_STATIC_KEY_TRUE_ARRAY(name, n) \
> + struct static_key_true name[n] = { [0 ... n - 1] = STATIC_KEY_TRUE_INIT }
> +
> +#define DEFINE_STATIC_KEY_FALSE_ARRAY(name, n) \
> + struct static_key_false name[n] = { [0 ... n - 1] = STATIC_KEY_FALSE_INIT }
I think the define makes the code more obfuscated and less clear, the open-coded
initialization is pretty dense and easy to read to begin with.
Thanks,
Ingo
next prev parent reply other threads:[~2015-08-21 6:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-20 12:14 [PATCH 0/8] powerpc: use jump label for {cpu,mmu}_has_feature() Kevin Hao
2015-08-20 12:14 ` [PATCH 1/8] jump_label: no need to acquire the jump_label_mutex in jump_lable_init() Kevin Hao
2015-08-20 18:29 ` Peter Zijlstra
2015-08-21 3:17 ` Kevin Hao
2015-08-20 12:14 ` [PATCH 2/8] jump_label: make it possible for the archs to invoke jump_label_init() much earlier Kevin Hao
2015-08-20 12:14 ` [PATCH 3/8] jump_label: introduce DEFINE_STATIC_KEY_{TRUE, FALSE}_ARRAY macros Kevin Hao
2015-08-20 18:31 ` [PATCH 3/8] jump_label: introduce DEFINE_STATIC_KEY_{TRUE,FALSE}_ARRAY macros Peter Zijlstra
2015-08-21 3:23 ` Kevin Hao
2015-08-21 6:28 ` Ingo Molnar [this message]
2015-08-21 6:34 ` Kevin Hao
2015-08-21 6:40 ` Ingo Molnar
2015-08-21 6:45 ` Kevin Hao
2015-08-20 12:14 ` [PATCH 4/8] powerpc: invoke jump_label_init() in a much earlier stage Kevin Hao
2015-08-20 12:14 ` [PATCH 5/8] powerpc: kill mfvtb() Kevin Hao
2015-08-20 12:14 ` [PATCH 6/8] powerpc: move the cpu_has_feature to a separate file Kevin Hao
2015-08-20 12:14 ` [PATCH 7/8] powerpc: use the jump label for cpu_has_feature Kevin Hao
2015-08-20 12:14 ` [PATCH 8/8] powerpc: use jump label for mmu_has_feature Kevin Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150821062826.GA566@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=benh@kernel.crashing.org \
--cc=haokexin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).