From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0121.outbound.protection.outlook.com [65.55.169.121]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 5FE121A0010 for ; Thu, 27 Aug 2015 06:56:10 +1000 (AEST) Date: Wed, 26 Aug 2015 15:55:54 -0500 From: Scott Wood To: Chenhui Zhao CC: , , Subject: Re: [PATCH v2, 4/5] PowerPC/mpc85xx: Add hotplug support on E5500 and E500MC cores Message-ID: <20150826205554.GB10582@home.buserror.net> References: <1440590988-25594-1-git-send-email-chenhui.zhao@freescale.com> <1440590988-25594-4-git-send-email-chenhui.zhao@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <1440590988-25594-4-git-send-email-chenhui.zhao@freescale.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Aug 26, 2015 at 08:09:47PM +0800, Chenhui Zhao wrote: > +int check_cpu_dead(unsigned int cpu) > +{ > + return per_cpu(cpu_state, cpu) == CPU_DEAD; > +} I'm not sure this needs to be a function versus open-coded, but if you do want to make it a function, make it more obvious from the caller side by changing it to: bool is_cpu_dead(unsigned int cpu); Otherwise if I see "if (check_cpu_dead(cpu))" I don't know if the if-block is executed if the CPU is dead or if it isn't. > diff --git a/arch/powerpc/platforms/85xx/smp.h b/arch/powerpc/platforms/85xx/smp.h > index 0b20ae3..8ee19a3 100644 > --- a/arch/powerpc/platforms/85xx/smp.h > +++ b/arch/powerpc/platforms/85xx/smp.h > @@ -6,6 +6,7 @@ > #ifdef CONFIG_SMP > void __init mpc85xx_smp_init(void); > int __init mpc85xx_setup_pmc(void); > +int __init fsl_rcpm_init(void); > #else Why wasn't this added in the patch that added fsl_rcpm_init()? -Scott