linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Gavin Shan <gwshan@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Gavin Shan <gwshan@linux.vnet.ibm.com>, linuxppc-dev@lists.ozlabs.org
Subject: Re: [1/2] powerpc/pseries: Fix corrupted pdn list
Date: Fri, 28 Aug 2015 11:42:34 +1000	[thread overview]
Message-ID: <20150828014234.GA32198@gwshan> (raw)
In-Reply-To: <1440725560.8076.0.camel@ellerman.id.au>

On Fri, Aug 28, 2015 at 11:32:40AM +1000, Michael Ellerman wrote:
>On Fri, 2015-08-28 at 11:09 +1000, Gavin Shan wrote:
>> On Fri, Aug 28, 2015 at 10:55:35AM +1000, Michael Ellerman wrote:
>> >On Thu, 2015-27-08 at 04:12:36 UTC, Gavin Shan wrote:
>> >> Commit cca87d30 ("powerpc/pci: Refactor pci_dn") introduced pdn
>> >> list for SRIOV VFs. It means the pdn is be put into the child list
>> >> of its parent pdn when the pdn is created. When doing PCI hot
>> >> unplugging on pSeries, the PCI device node as well as its pdn are
>> >> released through procfs entry "powerpc/ofdt". Some one else grabs
>> >> the memory chunk of the pdn and update it accordingly. At the same
>> >> time, the pdn is still tracked in the child list of parent pdn. It
>> >> leads to corrupted child list in the parent pdn.
>> >> 
>> >> This fixes above issue by removing the pdn from the child list of
>> >> its parent pdn when the device node is detached from the system.
>> >> Note the pdn is free'd when the device node is released if the
>> >> device node is dynamic one. Otherwise, the device node as well
>> >> as the pdn won't be released.
>> >> 
>> >> Fixes: cca87d30 ("powerpc/pci: Refactor pci_dn")
>> >
>> >That went into 4.1, so this should presumably go to stable?
>> 
>> Yeah, This should be put into 4.1 stable.
>
>OK thanks.
>
>I've added:
>
>  Cc: stable@vger.kernel.org # 4.1
>

Thanks, Michael :-)

>cheers
>
>

  reply	other threads:[~2015-08-28  1:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-27  4:12 [PATCH 1/2] powerpc/pseries: Fix corrupted pdn list Gavin Shan
2015-08-27  4:12 ` [PATCH 2/2] powerpc/pseries: Cleanup on pci_dn_reconfig_notifier() Gavin Shan
2015-08-30 21:20   ` [2/2] " Michael Ellerman
2015-08-28  0:55 ` [1/2] powerpc/pseries: Fix corrupted pdn list Michael Ellerman
2015-08-28  1:09   ` Gavin Shan
2015-08-28  1:32     ` Michael Ellerman
2015-08-28  1:42       ` Gavin Shan [this message]
2015-08-30 21:20 ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150828014234.GA32198@gwshan \
    --to=gwshan@linux.vnet.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).