From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-s390@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH v5 1/8] perf: Add a flags parameter to pmu txn interfaces
Date: Tue, 1 Sep 2015 15:11:53 -0700 [thread overview]
Message-ID: <20150901221153.GB4158@us.ibm.com> (raw)
In-Reply-To: <20150901103859.GP19282@twins.programming.kicks-ass.net>
Peter Zijlstra [peterz@infradead.org] wrote:
|
| when looking at this (I almost pressed A for apply) it occurred to me
| that we now keep double state, cpuhw->txn_flags and cpuhw->group_flag
| are basically the same thing.
|
| Would not something like the below avoid this duplication?
Yes, it makes sense to drop the duplication. Will similarly drop the usage
of PERF_EVENT_TXN from other architectures too and try it out.
Thanks,
Sukadev
next prev parent reply other threads:[~2015-09-01 22:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 6:49 [PATCH v5 0/8] perf: Implement group-read of events using txn interface Sukadev Bhattiprolu
2015-08-14 6:49 ` [PATCH v5 1/8] perf: Add a flags parameter to pmu txn interfaces Sukadev Bhattiprolu
2015-09-01 10:38 ` Peter Zijlstra
2015-09-01 22:11 ` Sukadev Bhattiprolu [this message]
2015-08-14 6:49 ` [PATCH v5 2/8] perf: Split perf_event_read() and perf_event_count() Sukadev Bhattiprolu
2015-08-14 6:49 ` [PATCH v5 3/8] perf: Rename perf_event_read_{one, group}, perf_read_hw Sukadev Bhattiprolu
2015-08-14 6:49 ` [PATCH v5 4/8] perf: Add group reads to perf_event_read() Sukadev Bhattiprolu
2015-08-14 6:49 ` [PATCH v5 5/8] perf: Invert perf_read_group() loops Sukadev Bhattiprolu
2015-08-14 6:49 ` [PATCH v5 6/8] perf: Add return value for perf_event_read() Sukadev Bhattiprolu
2015-08-14 6:49 ` [PATCH v5 7/8] Define PERF_PMU_TXN_READ interface Sukadev Bhattiprolu
2015-08-14 6:49 ` [PATCH v5 8/8] powerpc/perf/hv-24x7: Use " Sukadev Bhattiprolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150901221153.GB4158@us.ibm.com \
--to=sukadev@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=peterz@infradead.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).