From: Scott Wood <scottwood@freescale.com>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
<linux-kernel@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>,
Joakim Tjernlund <joakim.tjernlund@transmode.se>
Subject: Re: [PATCH] powerpc/book3s32: Only select PPC_HAVE_PMU on e600
Date: Fri, 4 Sep 2015 11:43:49 -0500 [thread overview]
Message-ID: <20150904164349.GA10337@home.buserror.net> (raw)
In-Reply-To: <20150903092704.2F4881A241D@localhost.localdomain>
On Thu, Sep 03, 2015 at 11:27:03AM +0200, Christophe Leroy wrote:
> On PPC832x, perf record/report reports martian addresses
>
> 2.62% perf_reseau4 libpthread-2.18.so [.] __libc_send
> 2.56% perf_reseau4 [kernel.kallsyms] [k] __ip_make_skb
> 1.62% perf_reseau4 [kernel.kallsyms] [k] __ip_append_data.isra.39
> 1.55% perf_reseau4 [kernel.kallsyms] [k] ip_finish_output
> 1.33% perf_reseau4 [unknown] [k] 0x7ffffd94
> 1.33% perf_reseau4 [unknown] [k] 0x7ffffd95
> 1.28% perf_reseau4 [unknown] [k] 0x7ffffd97
> 1.26% perf_reseau4 [unknown] [k] 0x7ffffda3
> 1.24% perf_reseau4 [unknown] [k] 0x7ffffd98
> 1.22% perf_reseau4 [unknown] [k] 0x7ffffd92
> 1.22% perf_reseau4 [unknown] [k] 0x7ffffd9b
> [.....]
>
> This is due to function perf_instruction_pointer() reading SPR SIAR
> which doesn't exist on e300 core. The perf_instruction_pointer() is
> redefined in arch/powerpc/perf/core-book3s.c when CONFIG_PPC_PERF_CTRS
> is selected.
>
> This patch moves the selection of CONFIG_PPC_HAVE_PMU in 86xx section
> so that CONFIG_PPC_PERF_CTRS won't be selected for other 6xx powerpc
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
So, what happens when a kernel is built that supports both 83xx and 86xx?
Plus, it's e300, not e600, that is the exception among 6xx-style cores.
-Scott
next prev parent reply other threads:[~2015-09-04 16:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 9:27 [PATCH] powerpc/book3s32: Only select PPC_HAVE_PMU on e600 Christophe Leroy
2015-09-03 9:47 ` Michael Ellerman
2015-09-04 16:43 ` Scott Wood [this message]
2015-09-04 18:00 ` christophe leroy
2015-09-04 18:31 ` Segher Boessenkool
2015-09-04 19:51 ` Segher Boessenkool
2015-09-09 22:24 ` Scott Wood
2015-09-10 0:47 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150904164349.GA10337@home.buserror.net \
--to=scottwood@freescale.com \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=joakim.tjernlund@transmode.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).