From: Michael Ellerman <mpe@ellerman.id.au>
To: Kevin Hao <haokexin@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
linuxppc-dev@lists.ozlabs.org, Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [v2,3/6] powerpc: kill mfvtb()
Date: Mon, 7 Sep 2015 19:29:42 +1000 (AEST) [thread overview]
Message-ID: <20150907092942.1EF38140281@ozlabs.org> (raw)
In-Reply-To: <1440415228-8006-4-git-send-email-haokexin@gmail.com>
On Mon, 2015-24-08 at 11:20:25 UTC, Kevin Hao wrote:
> This function is only used by get_vtb(). They are almost the same
> except the reading from the real register. Move the mfspr() to
> get_vtb() and kill the function mfvtb(). With this, we can eliminate
> the use of cpu_has_feature() in very core header file like reg.h.
> This is a preparation for the use of jump label for cpu_has_feature().
I don't mind this change. But can you elaborate a bit on the issue with using
cpu_has_feature() in reg.h? Just so I can understand the problem.
I assume you ended up in a big mess of includes when you tried to include
jump_label.h from reg.h?
cheers
next prev parent reply other threads:[~2015-09-07 9:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-24 11:20 [PATCH v2 0/6] powerpc: use jump label for {cpu,mmu}_has_feature() Kevin Hao
2015-08-24 11:20 ` [PATCH v2 1/6] jump_label: make it possible for the archs to invoke jump_label_init() much earlier Kevin Hao
2015-08-24 11:20 ` [PATCH v2 2/6] powerpc: invoke jump_label_init() in a much earlier stage Kevin Hao
2015-08-24 11:20 ` [PATCH v2 3/6] powerpc: kill mfvtb() Kevin Hao
2015-09-07 9:29 ` Michael Ellerman [this message]
2015-09-08 2:59 ` [v2,3/6] " Kevin Hao
2015-08-24 11:20 ` [PATCH v2 4/6] powerpc: move the cpu_has_feature to a separate file Kevin Hao
2015-08-24 11:20 ` [PATCH v2 5/6] powerpc: use the jump label for cpu_has_feature Kevin Hao
2015-08-24 11:20 ` [PATCH v2 6/6] powerpc: use jump label for mmu_has_feature Kevin Hao
2015-08-25 8:23 ` [PATCH v2 0/6] powerpc: use jump label for {cpu,mmu}_has_feature() Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150907092942.1EF38140281@ozlabs.org \
--to=mpe@ellerman.id.au \
--cc=haokexin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).