From: Michael Ellerman <mpe@ellerman.id.au>
To: Nishanth Aravamudan <nacc@linux.vnet.ibm.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Wei Yang <weiyang@linux.vnet.ibm.com>,
Gavin Shan <gwshan@linux.vnet.ibm.com>,
Paul Mackerras <paulus@samba.org>,
Hari Bathini <hbathini@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [v2] powerpc/powernv/pci-ioda: fix 32-bit TCE table init in kdump kernel
Date: Tue, 8 Sep 2015 22:05:01 +1000 (AEST) [thread overview]
Message-ID: <20150908120501.13340140129@ozlabs.org> (raw)
In-Reply-To: <20150902153928.GB47557@linux.vnet.ibm.com>
On Wed, 2015-02-09 at 15:39:28 UTC, Nishanth Aravamudan wrote:
> When attempting to kdump with the 4.2 kernel, we see for each PCI
> device:
>
> pci 0003:01 : [PE# 000] Assign DMA32 space
> pci 0003:01 : [PE# 000] Setting up 32-bit TCE table at 0..80000000
> pci 0003:01 : [PE# 000] Failed to create 32-bit TCE table, err -22
<snip>
> is a valid sanity check for pnv_pci_ioda2_table_alloc_pages(), so adjust
> the caller to pass in a smaller window size if our maximum memory value
> is smaller than the DMA window.
>
> After this change, the PCI devices successfully set up the 32-bit TCE
> table and kdump succeeds.
>
> The problem was seen on a Firestone machine originally.
>
> Fixes: aca6913f5551 ("powerpc/powernv/ioda2: Introduce helpers to allocate TCE pages")
> Signed-off-by: Nishanth Aravamudan <nacc@linux.vnet.ibm.com>
> Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/bb0054552d080dd929907c59
cheers
prev parent reply other threads:[~2015-09-08 12:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 1:11 [PATCH] powerpc/powernv/pci-ioda: fix 32-bit TCE table init in kdump kernel Nishanth Aravamudan
2015-09-02 9:00 ` Alexey Kardashevskiy
2015-09-02 15:39 ` [PATCH v2] " Nishanth Aravamudan
2015-09-03 9:58 ` Michael Ellerman
2015-09-03 15:59 ` Nishanth Aravamudan
2015-09-04 9:57 ` Michael Ellerman
2015-09-04 3:41 ` Alexey Kardashevskiy
2015-09-04 10:03 ` Michael Ellerman
2015-09-08 12:05 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150908120501.13340140129@ozlabs.org \
--to=mpe@ellerman.id.au \
--cc=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=gwshan@linux.vnet.ibm.com \
--cc=hbathini@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nacc@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=weiyang@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).