From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id BB1B21A0163 for ; Tue, 8 Sep 2015 22:05:01 +1000 (AEST) In-Reply-To: <1441621360-1536-1-git-send-email-bharata.rao@gmail.com> To: Bharata B Rao , linuxppc-dev@lists.ozlabs.org From: Michael Ellerman Cc: nfont@linux.vnet.ibm.com, Bharata B Rao Subject: Re: [FIX, v1] powerpc/pseries: Release DRC when configure_connector fails Message-Id: <20150908120501.A458B1402ED@ozlabs.org> Date: Tue, 8 Sep 2015 22:05:01 +1000 (AEST) List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2015-07-09 at 10:22:40 UTC, Bharata B Rao wrote: > From: Bharata B Rao > > Commit f32393c943e2 ("powerpc/pseries: Correct cpu affinity for > dlpar added cpus") moved dlpar_acquire_drc() call to before > dlpar_configure_connector() call in dlpar_cpu_probe(), but missed > to release the DRC if dlpar_configure_connector() failed. > During CPU hotplug, if configure-connector fails for any reason, > then this will result in subsequent CPU hotplug attempts to fail. > > Release the acquired DRC if dlpar_configure_connector() call fails > so that the DRC is left in right isolation and allocation state > for the subsequent hotplug operation to succeed. > > Signed-off-by: Bharata B Rao > Reviewed-by: Nathan Fontenot Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/daebaabb5cfbe4a6f09ca0e0 cheers