From: Scott Wood <scottwood@freescale.com>
To: Roy Pledge <Roy.Pledge@freescale.com>
Cc: <linuxppc-dev@lists.ozlabs.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [v2 04/11] soc/fsl: Introduce drivers for the DPAA QMan
Date: Fri, 11 Sep 2015 20:10:05 -0500 [thread overview]
Message-ID: <20150912011005.GA8796@home.buserror.net> (raw)
In-Reply-To: <1439410497-19039-5-git-send-email-Roy.Pledge@freescale.com>
On Wed, Aug 12, 2015 at 04:14:50PM -0400, Roy Pledge wrote:
> +/* Lock/unlock frame queues, subject to the "LOCKED" flag. This is about
> + * inter-processor locking only. Note, FQLOCK() is always called either under a
> + * local_irq_save() or from interrupt context - hence there's no need for irq
> + * protection (and indeed, attempting to nest irq-protection doesn't work, as
> + * the "irq en/disable" machinery isn't recursive...). */
> +#define FQLOCK(fq) \
> + do { \
> + struct qman_fq *__fq478 = (fq); \
> + if (fq_isset(__fq478, QMAN_FQ_FLAG_LOCKED)) \
> + spin_lock(&__fq478->fqlock); \
> + } while (0)
> +#define FQUNLOCK(fq) \
> + do { \
> + struct qman_fq *__fq478 = (fq); \
> + if (fq_isset(__fq478, QMAN_FQ_FLAG_LOCKED)) \
> + spin_unlock(&__fq478->fqlock); \
> + } while (0)
> +
I don't see QMAN_FQ_FLAG_LOCKED set anywhere. What is the use case?
-Scott
next prev parent reply other threads:[~2015-09-12 1:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 20:14 [v2 00/11] Freescale DPAA QBMan Drivers Roy Pledge
2015-08-12 20:14 ` [v2 01/11] powerpc: re-add devm_ioremap_prot() Roy Pledge
2015-08-12 20:14 ` [v2 02/11] soc/fsl: Introduce DPAA BMan device management driver Roy Pledge
2015-08-25 0:11 ` Scott Wood
2015-08-12 20:14 ` [v2 03/11] soc/fsl: Introduce the DPAA BMan portal driver Roy Pledge
2015-08-25 1:25 ` Scott Wood
2015-10-27 14:38 ` Sebastian Huber
2015-08-12 20:14 ` [v2 04/11] soc/fsl: Introduce drivers for the DPAA QMan Roy Pledge
2015-09-12 1:10 ` Scott Wood [this message]
2015-09-15 15:32 ` Roy Pledge
2015-08-12 20:14 ` [v2 05/11] soc/bman: Add self-tester for BMan driver Roy Pledge
2015-08-12 20:14 ` [v2 06/11] soc/qman: Add self-tester for QMan driver Roy Pledge
2015-08-12 20:14 ` [v2 07/11] soc/bman: Add debugfs support for the BMan driver Roy Pledge
2015-08-12 20:14 ` [v2 08/11] soc/qman: Add debugfs support for the QMan driver Roy Pledge
2015-08-12 20:14 ` [v2 09/11] soc/bman: Add HOTPLUG_CPU support to the BMan driver Roy Pledge
2015-08-12 20:14 ` [v2 10/11] soc/qman: Add HOTPLUG_CPU support to the QMan driver Roy Pledge
2015-08-12 20:14 ` [v2 11/11] soc/qman: add qman_delete_cgr_safe() Roy Pledge
2015-08-24 22:33 ` [v2 00/11] Freescale DPAA QBMan Drivers Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150912011005.GA8796@home.buserror.net \
--to=scottwood@freescale.com \
--cc=Roy.Pledge@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).