From: Michael Ellerman <mpe@ellerman.id.au>
To: Paul Mackerras <paulus@ozlabs.org>, linuxppc-dev@ozlabs.org
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>
Subject: Re: powerpc: MSI: Fix race condition in tearing down MSI interrupts
Date: Mon, 14 Sep 2015 12:55:39 +1000 (AEST) [thread overview]
Message-ID: <20150914025539.7985D140549@ozlabs.org> (raw)
In-Reply-To: <20150910043621.GA21735@iris.ozlabs.ibm.com>
On Thu, 2015-10-09 at 04:36:21 UTC, Paul Mackerras wrote:
> This fixes a race which can result in the same virtual IRQ number
> being assigned to two different MSI interrupts. The most visible
> consequence of that is usually a warning and stack trace from the
> sysfs code about an attempt to create a duplicate entry in sysfs.
<snip>
> The pattern of calling msi_bitmap_free_hwirqs() before
> irq_dispose_mapping() appears in 5 places under arch/powerpc, and
> appears to have originated in commit 05af7bd2d75e ("[POWERPC] MPIC
> U3/U4 MSI backend") from 2007.
>
> Reported-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> Signed-off-by: Paul Mackerras <paulus@samba.org>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/e297c939b745e420ef0b9dc9
cheers
prev parent reply other threads:[~2015-09-14 2:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 4:36 [PATCH] powerpc: MSI: Fix race condition in tearing down MSI interrupts Paul Mackerras
2015-09-10 4:55 ` Michael Ellerman
2015-09-10 5:26 ` Paul Mackerras
2015-09-14 2:55 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150914025539.7985D140549@ozlabs.org \
--to=mpe@ellerman.id.au \
--cc=aik@ozlabs.ru \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).