From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org, kernel@pengutronix.de
Subject: Re: [PATCH] powerpc: mpc512x: drop bogus and unused psc register bit definitions
Date: Fri, 18 Sep 2015 08:36:18 +0200 [thread overview]
Message-ID: <20150918063618.GS5327@pengutronix.de> (raw)
In-Reply-To: <1437463273-24742-1-git-send-email-u.kleine-koenig@pengutronix.de>
Hello,
On Tue, Jul 21, 2015 at 09:21:13AM +0200, Uwe Kleine-König wrote:
> These were introduced in commit 25ae3a0739c6 ("[POWERPC] mpc512x: Add
> MPC512x PSC support to MPC52xx psc driver") and never used. Moreover
> according to the datasheet[1] MEMERROR is bit 25 (0x40) and ORERR is
> bit 27 (0x10).
>
> [1] MPC5125RM Rev. 2; 11/2009
I didn't get any feedback for this patch yet. Do you still consider it?
Best regards
Uwe
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> arch/powerpc/include/asm/mpc52xx_psc.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/mpc52xx_psc.h b/arch/powerpc/include/asm/mpc52xx_psc.h
> index d0ece257d310..92806c24c2c5 100644
> --- a/arch/powerpc/include/asm/mpc52xx_psc.h
> +++ b/arch/powerpc/include/asm/mpc52xx_psc.h
> @@ -258,8 +258,6 @@ struct mpc52xx_psc_fifo {
> #define MPC512x_PSC_FIFO_FULL 0x2
> #define MPC512x_PSC_FIFO_ALARM 0x4
> #define MPC512x_PSC_FIFO_URERR 0x8
> -#define MPC512x_PSC_FIFO_ORERR 0x01
> -#define MPC512x_PSC_FIFO_MEMERROR 0x02
>
> struct mpc512x_psc_fifo {
> u32 reserved1[10];
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2015-09-18 6:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 7:21 [PATCH] powerpc: mpc512x: drop bogus and unused psc register bit definitions Uwe Kleine-König
2015-09-18 6:36 ` Uwe Kleine-König [this message]
2015-10-22 14:09 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150918063618.GS5327@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=benh@kernel.crashing.org \
--cc=kernel@pengutronix.de \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).