From: Christoph Hellwig <hch@lst.de>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org, hch@lst.de, JBottomley@Odin.com,
snitzer@redhat.com, hare@suse.de, martin.petersen@oracle.com
Subject: Re: [PATCH] powerpc/configs: Re-enable CONFIG_SCSI_DH
Date: Wed, 30 Sep 2015 17:03:29 +0200 [thread overview]
Message-ID: <20150930150329.GA26299@lst.de> (raw)
In-Reply-To: <1443522908-25523-1-git-send-email-mpe@ellerman.id.au>
On Tue, Sep 29, 2015 at 08:35:08PM +1000, Michael Ellerman wrote:
> Commit 086b91d052eb ("scsi_dh: integrate into the core SCSI code")
> changed CONFIG_SCSI_DH from tristate to bool.
>
> Our defconfigs have CONFIG_SCSI_DH=m, which the kconfig machinery warns
> us is invalid, but instead of converting it to =y it leaves it unset.
> This means we loose the CONFIG_SCSI_DH code and everything that depends
> on it.
>
> So convert the values in the defconfigs to =y.
>
> Fixes: 086b91d052eb ("scsi_dh: integrate into the core SCSI code")
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2015-09-30 15:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 10:35 [PATCH] powerpc/configs: Re-enable CONFIG_SCSI_DH Michael Ellerman
2015-09-30 15:03 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150930150329.GA26299@lst.de \
--to=hch@lst.de \
--cc=JBottomley@Odin.com \
--cc=hare@suse.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=martin.petersen@oracle.com \
--cc=mpe@ellerman.id.au \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).