From: Michael Ellerman <mpe@ellerman.id.au>
To: Andrew Donnellan <andrew.donnellan@au1.ibm.com>, linuxppc-dev@ozlabs.org
Cc: mikey@neuling.org, mrochs@linux.vnet.ibm.com,
imunsie@au1.ibm.com, vaibhav@linux.vnet.ibm.com
Subject: Re: [1/3] cxl: fix leak of IRQ names in cxl_free_afu_irqs()
Date: Thu, 1 Oct 2015 16:49:49 +1000 (AEST) [thread overview]
Message-ID: <20151001064949.5D0F0140D6F@ozlabs.org> (raw)
In-Reply-To: <1443578287-7847-1-git-send-email-andrew.donnellan@au1.ibm.com>
On Wed, 2015-30-09 at 01:58:05 UTC, Andrew Donnellan wrote:
> cxl_free_afu_irqs() doesn't free IRQ names when it releases an AFU's IRQ
> ranges. The userspace API equivalent in afu_release_irqs() calls
> afu_irq_name_free() to release the IRQ names.
>
> Call afu_irq_name_free() in cxl_free_afu_irqs() to release the IRQ names.
> Make afu_irq_name_free() non-static to allow this.
>
> Reported-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
> Fixes: 6f7f0b3df6d4 ("cxl: Add AFU virtual PHB and kernel API")
> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> Signed-off-by: Ian Munsie <imunsie@au1.ibm.com>
> Reviewed-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/8dde152ea34860403c839598
cheers
next prev parent reply other threads:[~2015-10-01 6:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 1:58 [PATCH 1/3] cxl: fix leak of IRQ names in cxl_free_afu_irqs() Andrew Donnellan
2015-09-30 1:58 ` [PATCH 2/3] cxl: fix leak of ctx->irq_bitmap when releasing context via kernel API Andrew Donnellan
2015-09-30 6:01 ` Ian Munsie
2015-09-30 14:04 ` Matthew R. Ochs
2015-10-01 6:51 ` [2/3] " Michael Ellerman
2015-09-30 1:58 ` [PATCH 3/3] cxl: fix leak of ctx->mapping when releasing kernel API contexts Andrew Donnellan
2015-09-30 6:02 ` Ian Munsie
2015-09-30 14:04 ` Matthew R. Ochs
2015-10-01 6:51 ` [3/3] " Michael Ellerman
2015-10-07 10:10 ` Michael Ellerman
2015-09-30 14:03 ` [PATCH 1/3] cxl: fix leak of IRQ names in cxl_free_afu_irqs() Matthew R. Ochs
2015-10-01 6:49 ` Michael Ellerman [this message]
2015-10-01 6:51 ` [1/3] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151001064949.5D0F0140D6F@ozlabs.org \
--to=mpe@ellerman.id.au \
--cc=andrew.donnellan@au1.ibm.com \
--cc=imunsie@au1.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=mrochs@linux.vnet.ibm.com \
--cc=vaibhav@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).