From: Wei Yang <weiyang@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Wei Yang <weiyang@linux.vnet.ibm.com>,
benh@kernel.crashing.org, paulus@samba.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/iommu: use iommu_num_pages() to calculate the number of iommu page
Date: Fri, 2 Oct 2015 06:51:59 +0800 [thread overview]
Message-ID: <20151001225159.GA6145@Richards-MBP.lan> (raw)
In-Reply-To: <1443672945.3058.0.camel@ellerman.id.au>
On Thu, Oct 01, 2015 at 02:15:45PM +1000, Michael Ellerman wrote:
>On Thu, 2015-10-01 at 07:50 +0800, Wei Yang wrote:
>> Hmm... some comments on this one? like it or not?
>
>It sounds like it's fixing a bug, but you don't really say. Have you seen this
>fail in the wild?
Hmm... as described in the commit log, this would be a bug when
PAGE_SIZE is much smaller than IOMMU Page Size. This configuration doesn't
happen on current platform. So I didn't see this failure yet.
>
>Which commit introduced the breakage?
Hmm... maybe we could say it is 'commit d084775738b7
<powerpc/iommu: Update the generic code to use dynamic iommu page sizes>'.
>From this commit, powerpc iommu supports dynamic iommu page size.
Before this commit, the size is aligned with PAGE_SIZE, so the value after
shift would be non-zero. After this commit, when PAGE_SIZE is smaller than
the IOMMU Page Size, shift right will make the size 0.
>
>cheers
>
--
Richard Yang
Help you, Help me
next prev parent reply other threads:[~2015-10-01 22:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-19 13:04 [PATCH] powerpc/iommu: use iommu_num_pages() to calculate the number of iommu page Wei Yang
2015-09-30 23:50 ` Wei Yang
2015-10-01 4:15 ` Michael Ellerman
2015-10-01 22:51 ` Wei Yang [this message]
2015-11-12 2:32 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151001225159.GA6145@Richards-MBP.lan \
--to=weiyang@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).