From: Michael Ellerman <mpe@ellerman.id.au>
To: Ian Munsie <imunsie@au1.ibm.com>,
Michael Ellerman <michaele@au1.ibm.com>,
Christophe Lombard <clombard@linux.vnet.ibm.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>,
Michael Neuling <mikey@neuling.org>,
Ian Munsie <imunsie@au1.ibm.com>, stable <stable@vger.kernel.org>
Subject: Re: cxl: Fix number of allocated pages in SPA
Date: Wed, 7 Oct 2015 21:10:55 +1100 (AEDT) [thread overview]
Message-ID: <20151007101055.BDE1D140D68@ozlabs.org> (raw)
In-Reply-To: <1444194460-13584-1-git-send-email-imunsie@au.ibm.com>
On Wed, 2015-07-10 at 05:07:40 UTC, Ian Munsie wrote:
> From: Christophe Lombard <clombard@linux.vnet.ibm.com>
>
> The scheduled process area is currently allocated before assigning the
> correct maximum processes to the AFU, which will mean we only ever
> allocate a fixed number of pages for the scheduled process area. This
> will limit us to 958 processes with 2 x 64K pages. If we try to use more
> processes than that we'd probably overrun the buffer and corrupt memory
> or crash.
>
> AFUs that require three or more interrupts per process will not be
> affected as they are already limited to less processes than that, but we
> could hit it on an AFU that requires 0, 1 or 2 interrupts per process,
> or when using 4K pages.
>
> This patch moves the initialisation of the num_procs to before the SPA
> allocation so that enough pages will be allocated for the number of
> processes that the AFU supports.
>
> Signed-off-by: Christophe Lombard <clombard@linux.vnet.ibm.com>
> Signed-off-by: Ian Munsie <imunsie@au1.ibm.com>
> Cc: stable <stable@vger.kernel.org> # 3.18+
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/4108efb02daa09cbb5db048a
cheers
prev parent reply other threads:[~2015-10-07 10:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 14:19 [PATCH v2] cxl: Fix number of allocated pages in SPA Christophe Lombard
2015-10-07 3:51 ` Ian Munsie
2015-10-07 4:09 ` Michael Ellerman
2015-10-07 5:07 ` [PATCH] " Ian Munsie
2015-10-07 10:10 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151007101055.BDE1D140D68@ozlabs.org \
--to=mpe@ellerman.id.au \
--cc=clombard@linux.vnet.ibm.com \
--cc=imunsie@au1.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=michaele@au1.ibm.com \
--cc=mikey@neuling.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).