From: Guenter Roeck <linux@roeck-us.net>
To: Chris Metcalf <cmetcalf@ezchip.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [GIT PULL] strscpy powerpc fix for 3.4
Date: Thu, 8 Oct 2015 11:45:41 -0700 [thread overview]
Message-ID: <20151008184541.GA8373@roeck-us.net> (raw)
In-Reply-To: <5615B87A.80206@ezchip.com>
On Wed, Oct 07, 2015 at 08:27:38PM -0400, Chris Metcalf wrote:
> On 10/7/2015 6:44 PM, Stephen Rothwell wrote:
> >Hi Linus,
> >
> >After merging Linus' tree, today's linux-next build (powerpc
> >ppc64_defconfig) failed like this:
> >
> >lib/string.c: In function 'strscpy':
> >lib/string.c:209:4: error: implicit declaration of function 'zero_bytemask' [-Werror=implicit-function-declaration]
> > *(unsigned long *)(dest+res) = c & zero_bytemask(data);
> > ^
> >
> >Caused by commit
> >
> > 30035e45753b ("string: provide strscpy()")
>
> I posted a change equivalent to yours earlier today:
>
> http://lkml.kernel.org/r/1444229188-19640-1-git-send-email-cmetcalf@ezchip.com
>
> I also did no testing, but since the rest of the PPC code is similar to the
> asm-generic version, I believe the zero_bytemask() definition should be OK.
>
> It probably should go through Linus' tree, like the previous set of patches.
> I just pushed it up to the linux-tile tree for Linus to grab as:
>
Wonder if Linus is going to realize that you meant 4.3 in your subject line,
not 3.4.
Guenter
> git://git.kernel.org/pub/scm/linux/kernel/git/cmetcalf/linux-tile.git strscpy
>
> Chris Metcalf (1):
> arch/powerpc: provide zero_bytemask() for big-endian
>
> arch/powerpc/include/asm/word-at-a-time.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> --
> Chris Metcalf, EZChip Semiconductor
> http://www.ezchip.com
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>
next prev parent reply other threads:[~2015-10-08 18:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 22:44 linux-next: build failure after merge of Linus' tree Stephen Rothwell
2015-10-08 0:27 ` [GIT PULL] strscpy powerpc fix for 3.4 Chris Metcalf
2015-10-08 18:45 ` Guenter Roeck [this message]
2015-10-08 19:47 ` [GIT PULL] strscpy powerpc fix for 4.3 - not 3.4 :-) Chris Metcalf
2015-10-10 0:39 ` [GIT PULL] strscpy powerpc fix for 3.4 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151008184541.GA8373@roeck-us.net \
--to=linux@roeck-us.net \
--cc=cmetcalf@ezchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).