From: David Miller <davem@davemloft.net>
To: igal.liberman@freescale.com
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, scottwood@freescale.com,
madalin.bucur@freescale.com, pebolle@tiscali.nl,
joakim.tjernlund@transmode.se, ppc@mindchasers.com,
stephen@networkplumber.org
Subject: Re: [v7, 2/6] fsl/fman: Add FMan support
Date: Mon, 02 Nov 2015 23:17:50 -0500 (EST) [thread overview]
Message-ID: <20151102.231750.1882562463767220834.davem@davemloft.net> (raw)
In-Reply-To: <1446467416-15992-3-git-send-email-igal.liberman@freescale.com>
From: <igal.liberman@freescale.com>
Date: Mon, 2 Nov 2015 14:30:12 +0200
> +static int clear_iram(struct fman *fman)
> +{
> + struct fman_iram_regs __iomem *iram;
> + int i, count;
> +
> + iram = (struct fman_iram_regs __iomem *)(fman->base_addr + IMEM_OFFSET);
"fman->base_addr" is of type "void __iomem *", therefore no cast should
be necessary at all.
Please audit your entire driver submission for this problem.
THanks.
next prev parent reply other threads:[~2015-11-03 4:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 12:30 [v7, 0/6] Freescale DPAA FMan igal.liberman
2015-11-02 12:30 ` [v7, 1/6] fsl/fman: Add FMan MURAM support igal.liberman
2015-11-02 12:30 ` [v7, 2/6] fsl/fman: Add FMan support igal.liberman
2015-11-03 4:17 ` David Miller [this message]
2015-11-02 12:30 ` [v7, 3/6] fsl/fman: Add FMan MAC support igal.liberman
2015-11-02 12:30 ` [v7, 4/6] fsl/fman: Add FMan SP support igal.liberman
2015-11-02 12:30 ` [v7, 5/6] fsl/fman: Add FMan Port Support igal.liberman
2015-11-04 0:45 ` kbuild test robot
2015-11-02 12:30 ` [v7, 6/6] fsl/fman: Add FMan MAC driver igal.liberman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151102.231750.1882562463767220834.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=igal.liberman@freescale.com \
--cc=joakim.tjernlund@transmode.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=madalin.bucur@freescale.com \
--cc=netdev@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=ppc@mindchasers.com \
--cc=scottwood@freescale.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).