From: Anton Blanchard <anton@samba.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Michael Neuling <mikey@neuling.org>,
benh@kernel.crashing.org, linuxppc-dev@ozlabs.org,
paulus@samba.org, sam.bobroff@au1.ibm.com
Subject: Re: [PATCH 1/5] powerpc: Print MSR TM bits in oops message
Date: Tue, 17 Nov 2015 09:07:46 +1100 [thread overview]
Message-ID: <20151117090746.0e8bf4ee@kryten> (raw)
In-Reply-To: <1447666040.2191.3.camel@ellerman.id.au>
Hi,
> > +{
> > + if (val & (MSR_TM | MSR_TS_S | MSR_TS_T)) {
> > + printk(",TM[");
> > + printbits(val, msr_tm_bits, "");
> > + printk("]");
>
> I suspect all these individual printks are going to behave badly if
> we have multiple cpus crashing simultaneously. But I won't make you
> fix that here. We should look at it sometime though.
We really need to serialise the entire oops. I had a go at fixing this
but ran out of steam:
https://lkml.org/lkml/2015/2/23/735
Anton
next prev parent reply other threads:[~2015-11-16 22:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-13 4:57 [PATCH 1/5] powerpc: Print MSR TM bits in oops message Michael Neuling
2015-11-13 4:57 ` [PATCH 2/5] selftests/powerpc: Add TM signal return selftest Michael Neuling
2015-11-16 10:24 ` Michael Ellerman
2015-11-17 10:12 ` Michael Neuling
2015-11-13 4:57 ` [PATCH 3/5] powerpc/tm: Block signal return setting invalid MSR state Michael Neuling
2015-11-16 10:05 ` Michael Ellerman
2015-11-17 10:30 ` Michael Neuling
2015-11-13 4:57 ` [PATCH 4/5] powerpc/tm: Check for already reclaimed tasks Michael Neuling
2015-11-16 7:21 ` Anshuman Khandual
2015-11-16 9:23 ` Michael Neuling
2015-11-16 9:33 ` Michael Ellerman
2015-11-16 10:21 ` Michael Neuling
2015-11-13 4:57 ` [PATCH 5/5] powerpc/tm: Clarify get_tm_stackpointer() by renaming it Michael Neuling
2015-11-16 9:51 ` Michael Ellerman
2015-11-16 7:22 ` [PATCH 1/5] powerpc: Print MSR TM bits in oops message Anshuman Khandual
2015-11-16 9:27 ` Michael Ellerman
2015-11-16 22:07 ` Anton Blanchard [this message]
2015-11-17 10:01 ` Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151117090746.0e8bf4ee@kryten \
--to=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=sam.bobroff@au1.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).