From: Rob Herring <robh@kernel.org>
To: Shengjiu Wang <shengjiu.wang@freescale.com>
Cc: pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
timur@tabi.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com,
lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com, shawnguo@kernel.org, alsa-devel@alsa-project.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH V2 3/3] ASoC: fsl_asrc: spba clock is needed by asrc device
Date: Fri, 20 Nov 2015 08:29:46 -0600 [thread overview]
Message-ID: <20151120142946.GA6949@rob-hp-laptop> (raw)
In-Reply-To: <7b40da78c965d4152c15794ec527c75198c9e2f9.1447997800.git.shengjiu.wang@freescale.com>
On Fri, Nov 20, 2015 at 02:17:53PM +0800, Shengjiu Wang wrote:
> ASRC need to enable the spba clock, when sdma is using share peripheral
> script. In this case, there is two spba master port is used, if don't
> enable the clock, the spba bus will have arbitration issue, which may
> cause read/write wrong data from/to ASRC registers
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@freescale.com>
> ---
> Documentation/devicetree/bindings/sound/fsl,asrc.txt | 2 ++
> sound/soc/fsl/fsl_asrc.c | 10 ++++++++++
> sound/soc/fsl/fsl_asrc.h | 1 +
> 3 files changed, 13 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl,asrc.txt b/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> index b93362a..d8eeee3 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> +++ b/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> @@ -25,6 +25,8 @@ Required properties:
> "mem" Peripheral access clock to access registers.
> "ipg" Peripheral clock to driver module.
> "asrck_<0-f>" Clock sources for input and output clock.
> + "spba" The spba clock is needed when two spba master port
> + is used.
I'm assuming the same comments on patch 1 apply to all 3.
Rob
next prev parent reply other threads:[~2015-11-20 14:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 6:17 [PATCH V2 0/3] add spba clock for fsl audio IP Shengjiu Wang
2015-11-20 6:17 ` [PATCH V2 1/3] ASoC: fsl_esai: spba clock is needed by esai device Shengjiu Wang
2015-11-20 7:39 ` Nicolin Chen
2015-11-20 6:17 ` [PATCH V2 2/3] ASoC: fsl_spdif: spba clk is needed by spdif device Shengjiu Wang
2015-11-20 6:17 ` [PATCH V2 3/3] ASoC: fsl_asrc: spba clock is needed by asrc device Shengjiu Wang
2015-11-20 14:29 ` Rob Herring [this message]
2015-11-20 22:00 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151120142946.GA6949@rob-hp-laptop \
--to=robh@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=nicoleotsuka@gmail.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@freescale.com \
--cc=timur@tabi.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox