From: Viresh Kumar <viresh.kumar@linaro.org>
To: Jia Hongtao <hongtao.jia@freescale.com>
Cc: edubezval@gmail.com, linux-pm@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org,
scottwood@freescale.com
Subject: Re: [PATCH] cpufreq: qoriq: Register cooling device based on device tree
Date: Tue, 24 Nov 2015 12:41:21 +0530 [thread overview]
Message-ID: <20151124071121.GM5258@ubuntu> (raw)
In-Reply-To: <1448348129-46675-1-git-send-email-hongtao.jia@freescale.com>
On 24-11-15, 14:55, Jia Hongtao wrote:
> + /* Register CPU cooling device for QorIQ platform */
> + for_each_node_with_property(cpu_np, "#cooling-cells") {
> + of_property_read_u32(cpu_np, "reg", &cpu_id);
> + cpufreq_get_policy(&cpu_policy, cpu_id);
That's not the right way to do it. You already have DT node for the
CPU, look at how it is done from ->ready() callback for cpufreq-dt.
--
viresh
next prev parent reply other threads:[~2015-11-24 7:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 6:55 [PATCH] cpufreq: qoriq: Register cooling device based on device tree Jia Hongtao
2015-11-24 7:11 ` Viresh Kumar [this message]
2015-11-25 8:00 ` Hongtao Jia
2015-11-24 14:18 ` Scott Wood
2015-11-24 17:24 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151124071121.GM5258@ubuntu \
--to=viresh.kumar@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=hongtao.jia@freescale.com \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).