* [PATCH] powerpc: IRQF_NO_SUSPEND not IRQF_TIMER for non-timer
@ 2015-11-11 14:15 John Ogness
2015-11-26 12:15 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: John Ogness @ 2015-11-11 14:15 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: Ian Campbell, linuxppc-dev, linux-kernel
Since gpio1 is not a timer, it also should not use IRQF_TIMER.
Similar to commit ba461f094bab ("powerpc: Use IRQF_NO_SUSPEND not
IRQF_TIMER for non-timer interrupts").
Signed-off-by: John Ogness <john.ogness@linutronix.de>
---
drivers/macintosh/via-pmu.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c
index f9512bf..01ee736 100644
--- a/drivers/macintosh/via-pmu.c
+++ b/drivers/macintosh/via-pmu.c
@@ -425,8 +425,9 @@ static int __init via_pmu_start(void)
gpio_irq = irq_of_parse_and_map(gpio_node, 0);
if (gpio_irq != NO_IRQ) {
- if (request_irq(gpio_irq, gpio1_interrupt, IRQF_TIMER,
- "GPIO1 ADB", (void *)0))
+ if (request_irq(gpio_irq, gpio1_interrupt,
+ IRQF_NO_SUSPEND, "GPIO1 ADB",
+ (void *)0))
printk(KERN_ERR "pmu: can't get irq %d"
" (GPIO1)\n", gpio_irq);
else
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: powerpc: IRQF_NO_SUSPEND not IRQF_TIMER for non-timer
2015-11-11 14:15 [PATCH] powerpc: IRQF_NO_SUSPEND not IRQF_TIMER for non-timer John Ogness
@ 2015-11-26 12:15 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2015-11-26 12:15 UTC (permalink / raw)
To: John Ogness, Benjamin Herrenschmidt
Cc: linuxppc-dev, Ian Campbell, linux-kernel
On Wed, 2015-11-11 at 14:15:03 UTC, John Ogness wrote:
> Since gpio1 is not a timer, it also should not use IRQF_TIMER.
>
> Similar to commit ba461f094bab ("powerpc: Use IRQF_NO_SUSPEND not
> IRQF_TIMER for non-timer interrupts").
>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/6c3082151e13846fd872cc21
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-26 12:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-11 14:15 [PATCH] powerpc: IRQF_NO_SUSPEND not IRQF_TIMER for non-timer John Ogness
2015-11-26 12:15 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).