linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [RESEND PATCH] powerpc: rackmeter: Fix module autoload for OF platform driver
@ 2015-10-20 15:13 Luis de Bethencourt
  2015-11-26 12:15 ` [RESEND] " Michael Ellerman
  0 siblings, 1 reply; 2+ messages in thread
From: Luis de Bethencourt @ 2015-10-20 15:13 UTC (permalink / raw)
  To: linux-kernel; +Cc: benh, linuxppc-dev, Luis de Bethencourt, Luis de Bethencourt

From: Luis de Bethencourt <luis@debethencourt.com>

This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---

Hi,

This is a resend of a patch sent September 17 [0]

This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
that information so modules have the correct aliases built-in and
autoloading works correctly.

A longer explanation by Javier Canillas can be found here:
https://lkml.org/lkml/2015/7/30/519

Thanks,
Luis

[0] https://lkml.org/lkml/2015/9/17/598

 drivers/macintosh/rack-meter.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/macintosh/rack-meter.c b/drivers/macintosh/rack-meter.c
index 048901a..caaec65 100644
--- a/drivers/macintosh/rack-meter.c
+++ b/drivers/macintosh/rack-meter.c
@@ -582,6 +582,7 @@ static struct of_device_id rackmeter_match[] = {
 	{ .name = "i2s" },
 	{ }
 };
+MODULE_DEVICE_TABLE(of, rackmeter_match);
 
 static struct macio_driver rackmeter_driver = {
 	.driver = {
-- 
2.5.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [RESEND] powerpc: rackmeter: Fix module autoload for OF platform driver
  2015-10-20 15:13 [RESEND PATCH] powerpc: rackmeter: Fix module autoload for OF platform driver Luis de Bethencourt
@ 2015-11-26 12:15 ` Michael Ellerman
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2015-11-26 12:15 UTC (permalink / raw)
  To: Luis de Bethencourt, linux-kernel
  Cc: Luis de Bethencourt, linuxppc-dev, Luis de Bethencourt

On Tue, 2015-20-10 at 15:13:53 UTC, Luis de Bethencourt wrote:
> From: Luis de Bethencourt <luis@debethencourt.com>
> 
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/6735b2e985b78e0ecb05e881

cheers

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-11-26 12:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-20 15:13 [RESEND PATCH] powerpc: rackmeter: Fix module autoload for OF platform driver Luis de Bethencourt
2015-11-26 12:15 ` [RESEND] " Michael Ellerman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).