linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc: set IRQF_NO_THREAD for xmon/cascade handlers
@ 2015-11-11 13:48 John Ogness
  2015-11-26 12:15 ` Michael Ellerman
  0 siblings, 1 reply; 2+ messages in thread
From: John Ogness @ 2015-11-11 13:48 UTC (permalink / raw)
  To: Benjamin Herrenschmidt; +Cc: linuxppc-dev, linux-kernel

The xmon and cascade irq handlers must not run as threads.
pmac_pic_lock is already a raw_spinlock, but the irq flag
IRQF_NO_THREAD needs to be set as well.

Signed-off-by: John Ogness <john.ogness@linutronix.de>
---
 arch/powerpc/platforms/powermac/pic.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/powermac/pic.c b/arch/powerpc/platforms/powermac/pic.c
index 6f4f8b0..9815463 100644
--- a/arch/powerpc/platforms/powermac/pic.c
+++ b/arch/powerpc/platforms/powermac/pic.c
@@ -258,13 +258,14 @@ static unsigned int pmac_pic_get_irq(void)
 #ifdef CONFIG_XMON
 static struct irqaction xmon_action = {
 	.handler	= xmon_irq,
-	.flags		= 0,
+	.flags		= IRQF_NO_THREAD,
 	.name		= "NMI - XMON"
 };
 #endif
 
 static struct irqaction gatwick_cascade_action = {
 	.handler	= gatwick_action,
+	.flags		= IRQF_NO_THREAD,
 	.name		= "cascade",
 };
 
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: powerpc: set IRQF_NO_THREAD for xmon/cascade handlers
  2015-11-11 13:48 [PATCH] powerpc: set IRQF_NO_THREAD for xmon/cascade handlers John Ogness
@ 2015-11-26 12:15 ` Michael Ellerman
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2015-11-26 12:15 UTC (permalink / raw)
  To: John Ogness, Benjamin Herrenschmidt; +Cc: linuxppc-dev, linux-kernel

On Wed, 2015-11-11 at 13:48:50 UTC, John Ogness wrote:
> The xmon and cascade irq handlers must not run as threads.
> pmac_pic_lock is already a raw_spinlock, but the irq flag
> IRQF_NO_THREAD needs to be set as well.
> 
> Signed-off-by: John Ogness <john.ogness@linutronix.de>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/57f889471c0fb55cbb0db98b

cheers

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-11-26 12:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-11 13:48 [PATCH] powerpc: set IRQF_NO_THREAD for xmon/cascade handlers John Ogness
2015-11-26 12:15 ` Michael Ellerman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).